Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestAllocatorCrossNamespace #1604

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Flaky: TestAllocatorCrossNamespace #1604

merged 1 commit into from
Jun 2, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Skip errors where the pod was not found. It's likely been deleted by another cleanup process at the same time.

Which issue(s) this PR fixes:

Closes #1603

Special notes for your reviewer:

🏇 conditions 🏇

@markmandel
Flaky: TestAllocatorCrossNamespace
c7e43a7 
Skip errors where the pod was not found. It's likely been deleted by
another cleanup process at the same time.

🏇 conditions 🏇

Closes googleforgames#1603
@markmandel markmandel added kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 2, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 82e2e7d9-7ee8-4f40-b7a5-d0a913a139ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1604/head:pr_1604 && git checkout pr_1604
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-c7e43a7

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m
Copy link
Contributor

pooneh-m commented Jun 2, 2020

Thanks for the fix @markmandel

@pooneh-m pooneh-m merged commit 628d93a into googleforgames:master Jun 2, 2020
@markmandel markmandel deleted the flaky/TestAllocatorCrossNamespace branch June 2, 2020 01:45
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @ilkercelikyilmaz
Flaky: TestAllocatorCrossNamespace (googleforgames#1604)
739d014 
Skip errors where the pod was not found. It's likely been deleted by
another cleanup process at the same time.

🏇 conditions 🏇

Closes googleforgames#1603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pooneh-m pooneh-m pooneh-m approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@pooneh-m pooneh-m

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Flaky: TestAllocatorCrossNamespace
4 participants
@markmandel @agones-bot @google-oss-robot @pooneh-m