Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debian version for CPP example #1609

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jun 3, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Use more recent and updated version of Debian OS which includes less vulnerabilities.

Which issue(s) this PR fixes:

For #1154

Special notes for your reviewer:

@aLekSer aLekSer added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jun 3, 2020
@aLekSer aLekSer requested review from markmandel and removed request for devjgm and dzlier-gcp June 3, 2020 07:49
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 962f705e-edad-4ec1-8c3c-5706777ba01b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1609/head:pr_1609 && git checkout pr_1609
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-c23d19e

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it all works, and pushing up!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: efe7077b-df88-413f-b0f4-a86427f7a1d5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1609/head:pr_1609 && git checkout pr_1609
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-4718355

@markmandel markmandel added this to the 1.7.0 milestone Jun 3, 2020
@markmandel markmandel merged commit 4a9af67 into googleforgames:master Jun 3, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants