-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some formatting issues in the allocator code. #1643
Fixed some formatting issues in the allocator code. #1643
Conversation
Build Failed 😱 Build Id: 22e103b2-7dd3-43b5-85fc-6fc4aeb4ae16 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
…code with a lock/unlock.
Build Succeeded 👏 Build Id: a8119ec2-99b7-4c20-b375-20d6e0716873 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: cc698e1f-e273-4cca-ba8c-0bddc85c016d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devloop0, pooneh-m, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Failed 😱 Build Id: 3104dc66-859c-443b-9c2a-4174946e13ea To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: ffaac092-d0e5-4692-bd8b-1b7ad6d27205 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Fixed some refactoring issues mentioned in: #1638
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer:
@roberthbailey these are the changes from the closed PR that you suggested. I responded to the comments you made in that one, but feel free to make other comments here as well.