Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some formatting issues in the allocator code. #1643

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Fixed some formatting issues in the allocator code. #1643

merged 4 commits into from
Jun 23, 2020

Conversation

devloop0
Copy link
Contributor

@devloop0 devloop0 commented Jun 23, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup

What this PR does / Why we need it:
Fixed some refactoring issues mentioned in: #1638

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
@roberthbailey these are the changes from the closed PR that you suggested. I responded to the comments you made in that one, but feel free to make other comments here as well.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 22e103b2-7dd3-43b5-85fc-6fc4aeb4ae16

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

cmd/allocator/main.go Outdated Show resolved Hide resolved
cmd/allocator/main.go Outdated Show resolved Hide resolved
cmd/allocator/main.go Outdated Show resolved Hide resolved
cmd/allocator/main.go Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a8119ec2-99b7-4c20-b375-20d6e0716873

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1643/head:pr_1643 && git checkout pr_1643
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-20ae088

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cc698e1f-e273-4cca-ba8c-0bddc85c016d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1643/head:pr_1643 && git checkout pr_1643
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-9541342

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devloop0, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3104dc66-859c-443b-9c2a-4174946e13ea

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ffaac092-d0e5-4692-bd8b-1b7ad6d27205

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1643/head:pr_1643 && git checkout pr_1643
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-62b4e5c

@roberthbailey roberthbailey merged commit 330c4d0 into googleforgames:master Jun 23, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
)

* Fixed some formatting issues in the code.

Co-authored-by: Nikhil Athreya <nathreya@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants