Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer tooling to Helm 3 #1647

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

This updates the developer tooling to Helm 3.

Tiller can happily live alongside Helm 2, but you will want to remove the Agones helm 2 install, as it will overlap with the Helm 3
installation.

If you want to hand remove Agones - delete the agones-system namespace, and remove all agones CRDs. (kubectl get crds | grep agones)

The tiller-deploy deployment can also be deleted from the Kubernetes namespace if you need to hand remove Helm 2 as well.

Which issue(s) this PR fixes:

Work on #1436

Special notes for your reviewer:

Before each build, one needs to manually remove the helm2 install of Agones, and then after each build of this PR, one should remove the helm 3 installation (helm uninstall agones --namespace=agones-system) otherwise we could end up with competing Agones installations.

This updates the developer tooling to Helm 3.

Tiller can happily live alongside Helm 2, but you will want to remove
the Agones helm 2 install, as it will overlap with the Helm 3
installation.

If you want to hand remove Agones - delete the agones-system namespace,
and remove all agones CRDs. (`kubectl get crds | grep agones`)

The `tiller-deploy` deployment can also be deleted from the Kubernetes
namespace if you need to hand remove Helm 2 as well.

Work on googleforgames#1436
@markmandel markmandel added kind/feature New features for Agones area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jun 25, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f7d68e65-88ac-48cf-9861-34afa82f9d1e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1647/head:pr_1647 && git checkout pr_1647
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-0fce1b3

build/Makefile Show resolved Hide resolved
build/Makefile Show resolved Hide resolved
build/Makefile Outdated Show resolved Hide resolved
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d1798d70-f850-470a-801a-e6f898c1f70b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8de6d395-eab3-431e-9686-da999f1267a8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 14535eea-a91c-4494-9e9e-21d48c8c7942

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6d7b133e-5a6f-42a2-a6a3-4fb28387476d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: db69d813-3ab2-41e3-968a-a7a7837eb23e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1647/head:pr_1647 && git checkout pr_1647
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-d09e658

@markmandel markmandel linked an issue Jun 26, 2020 that may be closed by this pull request
@markmandel markmandel merged commit 9a1d132 into googleforgames:master Jun 26, 2020
@markmandel markmandel deleted the build/helm3 branch June 26, 2020 00:13
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
* Update developer tooling to Helm 3

This updates the developer tooling to Helm 3.

Tiller can happily live alongside Helm 2, but you will want to remove
the Agones helm 2 install, as it will overlap with the Helm 3
installation.

If you want to hand remove Agones - delete the agones-system namespace,
and remove all agones CRDs. (`kubectl get crds | grep agones`)

The `tiller-deploy` deployment can also be deleted from the Kubernetes
namespace if you need to hand remove Helm 2 as well.

Work on googleforgames#1436

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move support from Helm 2 ➡ Helm 3
5 participants