Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Agones developer guide to point at faster targets #1656

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Update Agones developer guide to point at faster targets #1656

merged 2 commits into from
Jun 30, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Running make build or make test is probably not reasonable for developers to use in a development iteration loop - so pointing new developers instead at test-go and build-images, which is what is needed most of the time.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

@markmandel
Update developer guide to point at faster targets
e5a4ff8 
Running `make build` or `make test` is probably not reasonable for
developers to use in a development iteration loop - so pointing new
developers instead at `test-go` and `build-images`, which is what is
needed most of the time.
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jun 26, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d32bd690-ea5d-462c-8d93-7246c451caed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1656/head:pr_1656 && git checkout pr_1656
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-e5a4ff8

aLekSer
aLekSer approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also sometimes to safe even more time, if you have the same commit-id then make build-controller-image would be enough, if change touches only Agones controller itself.
I am using this script:

#!/bin/bash

export REGISTRY="gcr.io/your-image-registry"
#make  build-controller-image
make -j4 build-images
make gcloud-auth-docker
make push
#make gcloud-terraform-install
make install

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member Author

Also sometimes to safe even more time, if you have the same commit-id then make build-controller-image would be enough, if change touches only Agones controller itself.

This sounds like a good extra PR!

I tend to do:
make -j 4 build-images && make -j 4 push a lot!

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ed56ab0b-4c5a-4960-a980-22ae4479fb4b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6c296444-42b4-41e1-8da8-7b10b075ce38

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1e24dd29-5a50-400f-a5bc-4072d340683a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1656/head:pr_1656 && git checkout pr_1656
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-a317266

@markmandel markmandel merged commit 04f546f into googleforgames:master Jun 30, 2020
@markmandel markmandel deleted the dev/instructions branch June 30, 2020 17:15
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @aLekSer @ilkercelikyilmaz
Update developer guide to point at faster targets (googleforgames#1656)
bf18ac4 
Running `make build` or `make test` is probably not reasonable for
developers to use in a development iteration loop - so pointing new
developers instead at `test-go` and `build-images`, which is what is
needed most of the time.

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@aLekSer aLekSer

Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/S
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @google-oss-robot @aLekSer @googlebot