Flaky TestLocal

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Fixed an issue with time slipping in this test, causing equality test to fail.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

[roberthbailey]

I don't want to block this change, but using something like https://pkg.go.dev/github.com/google/go-cmp/cmp would make it easy to express things like "these should be equal except this one field" and might be worth considering using if this sort of pattern becomes common in our code base.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markmandel]

I don't want to block this change, but using something like https://pkg.go.dev/github.com/google/go-cmp/cmp would make it easy to express things like "these should be equal except this one field" and might be worth considering using if this sort of pattern becomes common in our code base.

Ooh! that's nice!

I didn't see anything similar in https://pkg.go.dev/github.com/stretchr/testify@v1.6.1/assert?tab=doc - but might be worth popping through it again just in case -- the list of assertions has grown considerably since we first started using the package!

[agones-bot]

Build Succeeded 👏

Build Id: 7af059c3-8ed3-4a6e-b62a-f2d6e0ae89b9

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.7.0-7360970
• image: gcr.io/agones-images/agones-sdk:1.7.0-7360970
• image: gcr.io/agones-images/agones-ping:1.7.0-7360970
• Linux C++ SDK (build): agonessdk-1.7.0-7360970-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.7.0-7360970.zip

A preview of the website (the last 30 builds are retained):

• https://7360970-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1665/head:pr_1665 && git checkout pr_1665
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-7360970

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 4490ca77-fb81-48e2-9224-b726554d9c2b

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.7.0-c0f708d
• image: gcr.io/agones-images/agones-sdk:1.7.0-c0f708d
• image: gcr.io/agones-images/agones-ping:1.7.0-c0f708d
• Linux C++ SDK (build): agonessdk-1.7.0-c0f708d-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.7.0-c0f708d.zip

A preview of the website (the last 30 builds are retained):

• https://c0f708d-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1665/head:pr_1665 && git checkout pr_1665
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-c0f708d