Flaky: e2e namespace deletion

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This fixes the issue if the e2e test tries to delete namespace that is already in a Terminating state.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

[agones-bot]

Build Succeeded 👏

Build Id: 55918f1e-7e29-45cc-8551-5155422db583

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.7.0-9eb68ea
• image: gcr.io/agones-images/agones-sdk:1.7.0-9eb68ea
• image: gcr.io/agones-images/agones-ping:1.7.0-9eb68ea
• Linux C++ SDK (build): agonessdk-1.7.0-9eb68ea-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.7.0-9eb68ea.zip

A preview of the website (the last 30 builds are retained):

• https://9eb68ea-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1666/head:pr_1666 && git checkout pr_1666
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-9eb68ea

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Failed 😱

Build Id: 95415ea1-c563-45b9-a9dc-5ba5263fc50d

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Wait, this is what this fix is supposed to fix:

time="2020-07-01 18:36:25.065" level=info msg="Starting e2e test(s)" featureGates="ContainerPortAllocation=true&Example=true&PlayerTracking=false&SDKWatchSendOnExecute=false" gameServerImage="gcr.io/agones-images/udp-server:0.21" namespace= perfOutputDir= pullSecret= stressTestLevel=0 version=
time="2020-07-01 18:36:25.180" level=error msg="failed to cleanup e2e namespaces" error="deleting namespace 1593628294 failed: Operation cannot be fulfilled on namespaces \"1593628294\": The system is ensuring all content is removed from this namespace.  Upon completion, this namespace will automatically be purged by the system."
FAIL	agones.dev/agones/test/e2e	0.182s

[roberthbailey]

🤷

[markmandel]

Think I worked it out. The errors from DeleteNamespace() was returning errors.Errorf(...) rather than errors.Wrapf(...), so the cause was lost.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Failed 😱

Build Id: 8ce84cbc-42de-41ca-ab35-bdc247636be9

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 745ce57f-6c54-4f2d-81a5-fde03c5f50d9

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.7.0-11cc373
• image: gcr.io/agones-images/agones-sdk:1.7.0-11cc373
• image: gcr.io/agones-images/agones-ping:1.7.0-11cc373
• Linux C++ SDK (build): agonessdk-1.7.0-11cc373-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.7.0-11cc373.zip

A preview of the website (the last 30 builds are retained):

• https://11cc373-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1666/head:pr_1666 && git checkout pr_1666
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-11cc373