Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to relevant AWS EKS documentation #1675

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Add links to relevant AWS EKS documentation #1675

merged 3 commits into from
Jul 15, 2020

Conversation

comerford
Copy link
Contributor

@comerford comerford commented Jul 3, 2020 •
edited
Loading

The IRSA example is oddly enough the most practical, given that it is a coincidence they used autoscaling as the purpose, but all 3 are useful

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Adds equivalent EKS documentation examples to the autoscaling page. I have followed those docs and successfully deployed an autoscaler for Agones on EKS

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@comerford
Add links to relevant AWS EKS documentation
fbdacee 
The IRSA example is oddly enough the most practical, given that it is a coincidence they used autoscaling as the purpose, but all 3 are useful
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 50620e94-a4ec-4ee3-9365-7d7612f15a23

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1675/head:pr_1675 && git checkout pr_1675
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-fbdacee

aLekSer
aLekSer suggested changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, please fix a typo.

@markmandel
Copy link
Collaborator

Just a gentle bump on this PR - would be great to have the typo fixed, so we can merge the change 👍

comerford and others added 2 commits July 15, 2020 01:35
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 30f9655b-6e34-4dd6-8145-54c40337701f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1675/head:pr_1675 && git checkout pr_1675
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-19f4c87

@markmandel
Copy link
Collaborator

@aLekSer waiting on you to approve, and we can merge 👍

aLekSer
aLekSer approved these changes Jul 15, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for an update

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, comerford, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 013f73c into googleforgames:master Jul 15, 2020
@markmandel markmandel added this to the 1.8.0 milestone Aug 11, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Aug 11, 2020
@comerford comerford deleted the patch-1 branch August 19, 2020 09:19
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@comerford @aLekSer @ilkercelikyilmaz
Add links to relevant AWS EKS documentation (googleforgames#1675)
bfcef31 
* Add links to relevant AWS EKS documentation

The IRSA example is oddly enough the most practical, given that it is a coincidence they used autoscaling as the purpose, but all 3 are useful

* Update site/content/en/docs/Advanced/scheduling-and-autoscaling.md

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer aLekSer approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

@aLekSer aLekSer

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@comerford @agones-bot @markmandel @google-oss-robot @aLekSer @googlebot