Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# sdk to list of supported SDKs in overview doc #1678

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

edmundlam
Copy link
Contributor

@edmundlam edmundlam commented Jul 7, 2020

Update the SDK overview documentation to add the C# sdk to the list of supported SDKs

What type of PR is this?

/kind documentation

What this PR does / Why we need it:
Updates documentation to add C# to the list of a supported SDKs in the overview page

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:

Update the SDK overview documentation to add the C# sdk to the list of supported SDKs
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@edmundlam
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 7, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d8af632f-efe2-4d08-a984-708fe48e4d24

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1678/head:pr_1678 && git checkout pr_1678
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-e1cfe8f

Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edmundlam, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit 67f0826 into googleforgames:master Jul 7, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Jul 7, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jul 7, 2020
@edmundlam edmundlam deleted the patch-1 branch July 9, 2020 20:55
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Update the SDK overview documentation to add the C# sdk to the list of supported SDKs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants