Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Fairwinds agones-allocator-client to third-party tools #1684

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Adding Fairwinds agones-allocator-client to third-party tools #1684

merged 1 commit into from
Jul 9, 2020

Conversation

sudermanjr
Copy link
Contributor

Signed-off-by: Andrew Suderman andrew@sudermanjr.com

What type of PR is this?
/kind documentation

What this PR does / Why we need it:

New page:
Screen Shot 2020-07-08 at 1 48 25 PM

Signed-off-by: Andrew Suderman <andrew@sudermanjr.com>
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sudermanjr
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 8, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1b9a803e-c7f4-4f26-be83-b61abcb4333e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Thanks for fixing the existing link!

It looks like the build failed on the sdk-conformance tests, which is unrelated to your documentation change so I've re-started the tests.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 07a7f428-c7fd-4ac0-8c3f-cd14c00fca77

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1684/head:pr_1684 && git checkout pr_1684
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-3e1a96a

Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for your contribution. \o/

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey, sudermanjr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit 21f8b3b into googleforgames:master Jul 9, 2020
@markmandel markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Jul 9, 2020
@markmandel markmandel added this to the 1.8.0 milestone Jul 9, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants