Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests update: Added require statements to gameserversets package #1696

Merged

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Jul 17, 2020

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / Why we need it:
Use require package to abort tests in order to avoid nil pointer exceptions.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: faf5c34b-a6a5-4946-93cb-04b946aca04d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@akremsa akremsa force-pushed the gameserversets_use_require branch from 5433020 to 1efe2ec Compare July 17, 2020 13:56
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 97d3c474-8158-4e29-a7e5-82d44f1c6ed3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1696/head:pr_1696 && git checkout pr_1696
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-1efe2ec

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 03af7d2e-3478-4ba5-9577-2d9f8d3b71a2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1696/head:pr_1696 && git checkout pr_1696
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-d904f2a

@roberthbailey roberthbailey merged commit 7e99486 into googleforgames:master Jul 21, 2020
@markmandel markmandel added this to the 1.8.0 milestone Aug 11, 2020
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 11, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Tests update: Added require statements to gameserversets package

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants