Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra troubleshooting steps. #1721

Merged
merged 4 commits into from
Jul 29, 2020
Merged

Add extra troubleshooting steps. #1721

merged 4 commits into from
Jul 29, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Consolidating more of the troubleshooting steps I usually advocate for
in Slack into our troubleshooting guide, to make helping users with
issues scale better.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Also fixed a small formatting issue in the GameServer reference that we
point to in the troubleshooting doc.

@markmandel
Add extra troubleshooting steps.
898a26a 
Consolidating more of the troubleshooting steps I usually advocate for
in Slack into our troubleshooting guide, to make helping users with
issues scale better.

Also fixed a small formatting issue in the GameServer reference that we
point to in the troubleshooting doc.
@markmandel markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones labels Jul 28, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2452a97d-162a-4066-a620-096da3ad9b3e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author 

time="2020-07-28 21:56:06.424" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=simple-fleet-cqt7j
time="2020-07-28 21:56:06.698" level=info msg="Namespace gsa-multicluster-local-596fe0ac-cbaa-4e6d-b505-95886f301649 is deleted"
--- FAIL: TestMultiClusterAllocationOnLocalCluster (0.01s)
    --- FAIL: TestMultiClusterAllocationOnLocalCluster/Distributed (323.80s)
        gameserverallocation_test.go:98: error waiting for fleet condition on fleet simple-fleet-cqt7j
FAIL
time="2020-07-28 21:56:06.890" level=info msg="Namespace 1595972959 is deleted"
FAIL	agones.dev/agones/test/e2e	407.170s
FAIL

Weird

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c495abea-06a6-4a97-96ca-74aab58254c7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1721/head:pr_1721 && git checkout pr_1721
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-898a26a

aLekSer
aLekSer suggested changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guideline looks great, but some minor nit should be fixed I think.

site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9401ffda-eb3f-431b-9da6-aa533cec9b4d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel @aLekSer
Apply suggestions from code review
390e690 
Applying review comments.

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9e307f86-16be-42a4-bbba-2303d912590b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1721/head:pr_1721 && git checkout pr_1721
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-390e690

aLekSer
aLekSer approved these changes Jul 29, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small nit, overall approve.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel @aLekSer
Update site/content/en/docs/Guides/troubleshooting.md
378a1b2 
Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dca8974a-d736-42b1-838b-d2c2688eb46f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1721/head:pr_1721 && git checkout pr_1721
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-378a1b2

@markmandel markmandel merged commit c09a883 into googleforgames:master Jul 29, 2020
@markmandel markmandel deleted the docs/troubleshooting-more branch July 29, 2020 21:48
@markmandel markmandel added this to the 1.8.0 milestone Jul 29, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @aLekSer @ilkercelikyilmaz
Add extra troubleshooting steps. (googleforgames#1721)
5432646 
* Add extra troubleshooting steps.

Consolidating more of the troubleshooting steps I usually advocate for
in Slack into our troubleshooting guide, to make helping users with
issues scale better.

Also fixed a small formatting issue in the GameServer reference that we
point to in the troubleshooting doc.

* Apply suggestions from code review

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@aLekSer aLekSer

Labels
approved cla: yes kind/documentation Documentation for Agones kind/feature New features for Agones size/M
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@markmandel @agones-bot @google-oss-robot @aLekSer @googlebot