-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small typo #1722
Fix small typo #1722
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Build Failed 😱 Build Id: 6bf7d797-8c47-4e7a-8450-5e11fabb92b3 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
@Alfred-Mountfield Thanks for noticing this, but you should change go files for this to take effect and pass CI system.
Run make gen-api-docs && make test-gen-api-docs locally and commit all changed files to this PR.
|
bad144f
to
315668a
Compare
Thanks, should have realised it was generated :) Took longer than expected to setup the project locally. Also took the opportunity to change one or two other grammatical points in the docs, not that it's really important |
Build Succeeded 👏 Build Id: 27b0deae-7bc1-4a5a-b9e8-4af9686e2f76 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Failed 😱 Build Id: c3c36f3d-f5d8-43a5-bc6a-ea72bd0f4010 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 5e8c2b87-f9c0-4fb0-93e0-1771d86ef036 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Alfred-Mountfield, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Mark Mandel <markmandel@google.com>
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Fixes tiny typo
Special notes for your reviewer: