Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typo #1722

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Fix small typo #1722

merged 2 commits into from
Jul 29, 2020

Conversation

Alfred-Mountfield
Copy link

@Alfred-Mountfield Alfred-Mountfield commented Jul 29, 2020

What type of PR is this?

/kind documentation

What this PR does / Why we need it:
Fixes tiny typo

Special notes for your reviewer:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Alfred-Mountfield
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6bf7d797-8c47-4e7a-8450-5e11fabb92b3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer aLekSer added area/site The website itself - including redirects, styling, search, etc kind/documentation Documentation for Agones labels Jul 29, 2020
@aLekSer
Copy link
Collaborator

aLekSer commented Jul 29, 2020

@Alfred-Mountfield Thanks for noticing this, but you should change go files for this to take effect and pass CI system.

// Depoyments and ReplicaSets

Run make gen-api-docs && make test-gen-api-docs locally and commit all changed files to this PR.

@Alfred-Mountfield
Copy link
Author

Alfred-Mountfield commented Jul 29, 2020

Thanks, should have realised it was generated :)

Took longer than expected to setup the project locally. Also took the opportunity to change one or two other grammatical points in the docs, not that it's really important

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 27b0deae-7bc1-4a5a-b9e8-4af9686e2f76

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1722/head:pr_1722 && git checkout pr_1722
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-315668a

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c3c36f3d-f5d8-43a5-bc6a-ea72bd0f4010

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5e8c2b87-f9c0-4fb0-93e0-1771d86ef036

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1722/head:pr_1722 && git checkout pr_1722
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-5c7a006

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Alfred-Mountfield, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit f346b26 into googleforgames:master Jul 29, 2020
@markmandel markmandel added this to the 1.8.0 milestone Jul 29, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/site The website itself - including redirects, styling, search, etc cla: yes kind/documentation Documentation for Agones lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants