Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests update: migration, pernodcounter #1726

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Tests update: migration, pernodcounter #1726

merged 2 commits into from
Aug 5, 2020

Conversation

akremsa
Copy link
Contributor

@akremsa akremsa commented Jul 30, 2020

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / Why we need it:
Abort tests in proper places using require package.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 16caa1ab-18bb-43c4-b166-ab19248b1cfe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1726/head:pr_1726 && git checkout pr_1726
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-b6715eb

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a69da20b-054a-4da1-b075-b17f65618b1b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1726/head:pr_1726 && git checkout pr_1726
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-e108905

@markmandel markmandel merged commit 032cd08 into googleforgames:master Aug 5, 2020
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 5, 2020
@markmandel markmandel added this to the 1.8.0 milestone Aug 5, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@alexey-kremsa-globant @markmandel @ilkercelikyilmaz
made several fixes in tests - gameservers pkg (googleforgames#1726)
9e84d3e 
Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@akremsa @agones-bot @google-oss-robot @markmandel @googlebot @alexey-kremsa-globant