-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Terraform: Use docker image project default #1730
Build Terraform: Use docker image project default #1730
Conversation
This fixes the issue if your local gcloud setup points to a different project than the build shell, but pulling the current project from the build image configuration. Also snuck in the change that we don't need to specifically remove the helm module before removing the entire cluster as well.
Build Succeeded 👏 Build Id: fbaba5d1-e0c5-49c8-9c69-6bd2c96a869d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for an update.
This fixes the issue if your local gcloud setup points to a different project than the build shell, but pulling the current project from the build image configuration. Also snuck in the change that we don't need to specifically remove the helm module before removing the entire cluster as well.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This fixes the issue if your local gcloud setup points to a different
project than the build shell, but pulling the current project from the
build image configuration.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Also snuck in the change that we don't need to specifically remove the
helm module before removing the entire cluster as well.