Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Terraform: Use docker image project default #1730

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This fixes the issue if your local gcloud setup points to a different
project than the build shell, but pulling the current project from the
build image configuration.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Also snuck in the change that we don't need to specifically remove the
helm module before removing the entire cluster as well.

This fixes the issue if your local gcloud setup points to a different
project than the build shell, but pulling the current project from the
build image configuration.

Also snuck in the change that we don't need to specifically remove the
helm module before removing the entire cluster as well.
@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Aug 1, 2020
@markmandel markmandel requested review from aLekSer and removed request for EricFortin August 1, 2020 01:48
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fbaba5d1-e0c5-49c8-9c69-6bd2c96a869d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1730/head:pr_1730 && git checkout pr_1730
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-4bd7180

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 0a40ebe into googleforgames:master Aug 3, 2020
@markmandel markmandel deleted the build/tf-default branch August 3, 2020 04:51
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for an update.

@markmandel markmandel added this to the 1.8.0 milestone Aug 11, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
This fixes the issue if your local gcloud setup points to a different
project than the build shell, but pulling the current project from the
build image configuration.

Also snuck in the change that we don't need to specifically remove the
helm module before removing the entire cluster as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/bug These are bugs. lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants