Terraform Helm enforcing string for set values #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the most recent Helm provider forces that set value to be a string. Since we set it as an array in the Terraform value, this fix does the work to convert it to Helm array syntax. See: https://helm.sh/docs/intro/using_helm/#the-format-and-limitations-of---set
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: 122dadaf-74a0-4eea-a743-9475e0f885e8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
Looks like the most recent Helm provider forces that set value to be a string. Since we set it as an array in the Terraform value, this fix does the work to convert it to Helm array syntax. See: https://helm.sh/docs/intro/using_helm/#the-format-and-limitations-of---set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Looks like the most recent Helm provider forces that set value to be a
string.
Since we set it as an array in the Terraform value, this fix does the
work to convert it to Helm array syntax.
See:
https://helm.sh/docs/intro/using_helm/#the-format-and-limitations-of---set
Which issue(s) this PR fixes:
Found this while I'm slowly removing deployment manager! (I should probably have a ticket for this)
Special notes for your reviewer:
None