Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Uninstall instructions when using install.yaml #1783

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Add Uninstall instructions when using install.yaml #1783

merged 2 commits into from
Sep 9, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Sep 2, 2020 •
edited
Loading

Add some instructions on how to delete Agones resources and remove the agones-system
namespace.

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
We have instructions how to helm uninstall agones, but there is no details on how to properly cleanup cluster, after using kubectl apply -f ./install.yaml
Which issue(s) this PR fixes:

Closes #1778

Special notes for your reviewer:

Without kubectl delete gameservers and fleets steps, kubectl delete -f stucks on removing gameservers CRD.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 072bb774-1309-4e65-a277-722a660da773

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1783/head:pr_1783 && git checkout pr_1783
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-f31a839

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c281e91e-b184-4353-a51f-b599c6881cd7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1783/head:pr_1783 && git checkout pr_1783
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-f0393fe

@aLekSer aLekSer added the area/site The website itself - including redirects, styling, search, etc label Sep 3, 2020
markmandel
markmandel reviewed Sep 3, 2020
View reviewed changes
site/content/en/docs/Installation/Install Agones/yaml.md Outdated

```bash
$ kubectl delete fleets --all
$ kubectl delete gameservers --all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

$ kubectl delete fleets --all --all-namespaces
$ kubectl delete gameservers --all --all-namespaces

?

@aLekSer
Add Uninstall instructions when using install.yaml
ab7b021 
Add some instructions on how to delete Agones resources and remove the
namespace.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 475caed4-9346-4e19-8134-6bca9dc38ae0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1783/head:pr_1783 && git checkout pr_1783
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-ab7b021

domgreen
domgreen reviewed Sep 4, 2020
View reviewed changes
site/content/en/docs/Installation/Install Agones/yaml.md
$ kubectl delete namespace agones-system
```

Note: you should wait up to a couple of minutes until all resources described in `install.yaml` file would be deleted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to add any info for troubleshooting if you end up with the namespace in a terminating state, WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not reproduce an original issue if I follow these 4 commands one by one. If you can, please tell me so I can add some info into a Troubleshooting section.
I have added this Note, because kubectl delete is frozen up to 2 minutes before exiting. Also I saw a similar comment in a separate ticket about this being slow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right if you follow those commands it doesnt occour 👍 was meaning if anyone didnt uninstall correctly it would be helpful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domgreen maybe a separate PR in https://agones.dev/site/docs/guides/troubleshooting/ ?

@domgreen domgreen mentioned this pull request Sep 5, 2020
Merged
markmandel
markmandel approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dd2dc598-f9fa-4706-8922-4fdcfa445e2c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1783/head:pr_1783 && git checkout pr_1783
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-7057a96

@markmandel markmandel merged commit 8a11607 into googleforgames:master Sep 9, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 9, 2020
@aLekSer aLekSer deleted the docs/add-uninstall-yaml branch September 17, 2020 07:00
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @markmandel @ilkercelikyilmaz
Add Uninstall instructions when using install.yaml (googleforgames#1783)
1b7f586 
Add some instructions on how to delete Agones resources and remove the
namespace.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domgreen domgreen domgreen left review comments

@markmandel markmandel markmandel approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved area/site The website itself - including redirects, styling, search, etc cla: yes size/S
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

agones-system gets stuck in "Terminating"
6 participants
@aLekSer @agones-bot @google-oss-robot @domgreen @markmandel @googlebot