Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE4 small nit about float to float comparison #1792

Merged
merged 3 commits into from
Sep 11, 2020
Merged

UE4 small nit about float to float comparison #1792

merged 3 commits into from
Sep 11, 2020

Conversation

domgreen
Copy link
Contributor

@domgreen domgreen commented Sep 4, 2020

What type of PR is this?
/kind cleanup

What this PR does / Why we need it:
Small nit in the UE4 code. Comparison should be between same types.

cc @tomnetspeak who originally raised it 😄

@domgreen
Copy link
Contributor Author

domgreen commented Sep 4, 2020

@achynes would you mind confirming this is a good thing 👍

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a2ad15cc-a503-45fe-9d31-2c099278a050

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1792/head:pr_1792 && git checkout pr_1792
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-b67f6d3

@markmandel
Copy link
Member

Calling our Unreal user base:
@drichardson @dotcom @WVerlaek @robbieheywood

if someone could give me a 👍 , I'll get this merged!

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels Sep 8, 2020
@markmandel
Copy link
Member

I'm taking that 👍 as a win 😄 approving.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: domgreen, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1457e628-5d0b-46a9-85f6-86246bea1bda

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f625223a-a031-4c62-921f-fe1a34c419af

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: deba5e57-aa54-4366-ba36-bf5183331f95

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 5804d932-2a1a-493f-997f-70ed0bf55f35

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1792/head:pr_1792 && git checkout pr_1792
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-7e22dc2

@markmandel markmandel merged commit a9128db into googleforgames:master Sep 11, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 11, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants