-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UE4 small nit about float to float comparison #1792
Conversation
@achynes would you mind confirming this is a good thing 👍 |
Build Succeeded 👏 Build Id: a2ad15cc-a503-45fe-9d31-2c099278a050 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Calling our Unreal user base: if someone could give me a 👍 , I'll get this merged! |
I'm taking that 👍 as a win 😄 approving. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: domgreen, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 1457e628-5d0b-46a9-85f6-86246bea1bda To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: f625223a-a031-4c62-921f-fe1a34c419af To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: deba5e57-aa54-4366-ba36-bf5183331f95 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 👏 Build Id: 5804d932-2a1a-493f-997f-70ed0bf55f35 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Co-authored-by: Mark Mandel <markmandel@google.com>
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Small nit in the UE4 code. Comparison should be between same types.
cc @tomnetspeak who originally raised it 😄