Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock to to sdk-conformance compare() #1801

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Likely isn't an issue, but figure it wouldn't hurt, and probably should be there anyway.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:
N/A

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Sep 8, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 49836412-313c-4b78-8c70-4cf5eb2fc75b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Likely isn't an issue, but figure it wouldn't hurt, and
probably should be there anyway.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 84b601ae-7f27-4484-a46e-686fcb024a89

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1801/head:pr_1801 && git checkout pr_1801
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-1e3c771

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that this mutex could help.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit c8f18fa into googleforgames:master Sep 9, 2020
@markmandel markmandel deleted the cleanup/sdk-conf-lock branch September 9, 2020 16:21
@markmandel markmandel added this to the 1.9.0 milestone Sep 9, 2020
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Sep 22, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Likely isn't an issue, but figure it wouldn't hurt, and
probably should be there anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants