Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun Agones CRD client generation #1807

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

We updated the crd generation tooling with the update to Kubernetes 1.16.5 - this re-runs that tooling.

Which issue(s) this PR fixes:

Work on #1649

Special notes for your reviewer:

Only a very small change!

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Sep 11, 2020
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I also got this change after applying a previous PR.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d8ef44b3-544b-4877-b27f-b794d9a4c803

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6aa97e8e-483e-402a-81e3-ce4694302b55

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented Sep 11, 2020

E2E one:

--- FAIL: TestUnhealthyGameServersWithoutFreePorts (346.82s)
    gameserver_test.go:205: 
        	Error Trace:	gameserver_test.go:205
        	Error:      	Expected nil, but got: &errors.errorString{s:"waiting for {udp-server [{gameport Static <nil> 7654 5555 UDP}] {false 0 0 0}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []} {[] [] [{udp-server gcr.io/agones-images/simple-game-server:0.1 [] []  [] [] [] {map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}] map[cpu:{{30 -3} {<nil>} 30m DecimalSI} memory:{{33554432 0} {<nil>}  BinarySI}]} [] [] nil nil nil nil   IfNotPresent nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] []}} <nil>} GameServer instance readiness timed out (): waiting for GameServer to be Ready 1599867035/udp-server79988: timed out waiting for the condition"}
        	Test:       	TestUnhealthyGameServersWithoutFreePorts

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b215ec00-ae5d-4adf-af1b-f2ba9be66bc3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1807/head:pr_1807 && git checkout pr_1807
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-197f4d6

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1a18b5ad-f9be-47c7-9800-301b553ccd85

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1807/head:pr_1807 && git checkout pr_1807
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-f283bce

@markmandel markmandel merged commit d7dd795 into googleforgames:master Sep 14, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 14, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Only a small change

Work on googleforgames#1649

Co-authored-by: Robert Bailey <robertbailey@google.com>
@markmandel markmandel deleted the upgrade/regen branch October 27, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants