Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Doc] Mark multicluster allocation feature as stable" #1842

Merged
merged 6 commits into from
Oct 7, 2020
Merged

Revert "[Doc] Mark multicluster allocation feature as stable" #1842

merged 6 commits into from
Oct 7, 2020

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Oct 7, 2020

Reverts #1831

@google-cla google-cla bot added the cla: yes label Oct 7, 2020
aLekSer
aLekSer approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Robert we need to add website shortcodes releaseVersion and expiry.

@pooneh-m pooneh-m requested review from roberthbailey and removed request for cyriltovena October 7, 2020 18:49
aLekSer
aLekSer suggested changes Oct 7, 2020
View reviewed changes
site/content/en/docs/Guides/feature-stages.md Outdated
@@ -26,12 +26,20 @@ The current set of `alpha` and `beta` feature gates are:

| Feature Name | Gate | Default | Stage | Since |
|--------------|---------|---------|-------|-------|
{{% feature expiryVersion="1.10.0" %}}
Copy link
Collaborator

@aLekSer aLekSer Oct 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would break the table. Let's do separately this PR Revert only + another with New version. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 24a5fc41-6d8e-4b67-8cf5-0be403cb8237

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 9863117b-4d0b-46b8-a2be-e45a24992494

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 41866d20-b8d7-4e0e-b870-9823c789acd9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aLekSer,pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer
Copy link
Collaborator

aLekSer commented Oct 7, 2020 •
edited
Loading

429 errors on Github links.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bef5556e-5f8e-466e-9cf5-7bb7452487b2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ddebe01c-3367-478d-90d8-1180819598ab

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9459a302-dc56-4e3a-b1f7-6eb13db83d36

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1842/head:pr_1842 && git checkout pr_1842
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-5b9a2e4

@pooneh-m pooneh-m merged commit 5c5f752 into master Oct 7, 2020
@aLekSer aLekSer deleted the revert-1831-master branch October 8, 2020 13:51
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@pooneh-m @ilkercelikyilmaz
Revert "[Doc] Mark multicluster allocation feature as stable" (google…
d69a5d5 
…forgames#1842)

* Revert "[Doc] Mark multicluster allocation feature as stable (googleforgames#1831)"

This reverts commit c575f40.

* Update multi-cluster-allocation.md

* Update multi-cluster-allocation.md

* Update feature-stages.md

* Update multi-cluster-allocation.md

* Update feature-stages.md
@markmandel markmandel added this to the 1.10.0 milestone Nov 3, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer aLekSer approved these changes

Assignees

@aLekSer aLekSer

@roberthbailey roberthbailey

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pooneh-m @agones-bot @google-oss-robot @aLekSer @roberthbailey @markmandel