Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiCluster Allocation: Cleanup on error logs #1862

Merged
merged 3 commits into from
Oct 22, 2020
Merged

MultiCluster Allocation: Cleanup on error logs #1862

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9383ec
MultiCluster Allocation: Cleanup on error logs
markmandel Oct 22, 2020
a0578d3
Merge branch 'master' into cleanup/error-multi
markmandel Oct 22, 2020
5a38315
Merge branch 'master' into cleanup/error-multi
markmandel Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/gameserverallocations/allocator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@ func (c *Allocator) allocateFromRemoteCluster(gsa *allocationv1.GameServerAlloca
c.loggerForGameServerAllocationKey("remote-allocation").WithField("request", request).WithField("endpoint", endpoint).Debug("forwarding allocation request")
allocationResponse, err = c.remoteAllocationCallback(ctx, endpoint, dialOpts, request)
if err != nil {
c.baseLogger.Errorf("remote allocation failed with: %v", err)
// If there are multiple enpoints for the allocator connection and the current one is
c.baseLogger.WithError(err).Error("remote allocation failed with")
// If there are multiple endpoints for the allocator connection and the current one is
// failing, try the next endpoint. Otherwise, return the error response.
if (i + 1) < len(connectionInfo.AllocationEndpoints) {
// If there is a server error try a different endpoint
Expand Down