Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csharp SDK: exposes the Alpha SDK via the main interface #1896

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

rcreasey
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / Why we need it:
Exposes the alpha sdk object for those who implement their code against the main IAgonesSDK interface in the csharp SDK.

This is for classes like so:

public class AgonesStateService {
    private readonly IAgonesSDK m_agonesClient;
    public AgonesStateService(IAgonesSDK agonesClient) {
      m_agonesClient = agonesClient ?? new AgonesSDK();
    }
}

I want to be able to access the Alpha SDK methods like this:

private async Task<bool> PlayerConnectAsync(string playerId) {
    await m_agonesClient.Alpha().PlayerConnectAsync(playerId);
}

Without this change, I would have to implement code directly against the AgonesSDK.

Special notes for your reviewer:
(If there is another intended way this was to be exposed, let me know. I wish I would have suggested this in the original PR)

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, rcreasey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bcaa7fe6-6f25-4690-81a8-015e13c4ec68

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1896/head:pr_1896 && git checkout pr_1896
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-f8db718

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Nov 11, 2020
@markmandel markmandel merged commit 6333cc0 into googleforgames:master Nov 11, 2020
@markmandel markmandel added the area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc label Nov 11, 2020
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants