Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge allocation service annotation metadata #1908

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This worked previously, but cleaning things up so it's just one annotation section, where previously it was two.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2203a560-c37e-4ac5-8f35-50055bd6237c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

This worked previously, but cleaning things up so it's just one
annotation section, where previously it was two.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 28ea4ad5-16b0-40ac-add0-9dc4c08d6938

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1908/head:pr_1908 && git checkout pr_1908
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-5710022

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 145b999 into googleforgames:master Nov 25, 2020
@markmandel markmandel deleted the cleanup/allocation-service branch November 25, 2020 00:45
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
@markmandel markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants