Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move admissionregistration to v1 #1919

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Move admissionregistration to v1 #1919

merged 1 commit into from
Dec 9, 2020

Conversation

markmandel
Copy link
Member

Updates the webhook configuration to use the v1 version of WebhookClientConfig.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #1799

Special notes for your reviewer:

There are no changes in configuration, so it's no change to the end user experience.

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cba1bac8-e0e7-4d9c-8688-f0899c266a09

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1919/head:pr_1919 && git checkout pr_1919
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-68bcf34

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

This PR can't be updated automatically (due to conflicts) so I can't update it and merge it tonight.

@markmandel
Move admissionregistration to v1
d96d485 
Updates the webhook configuration to use the v1 version of
WebhookClientConfig.

There are no changes in configuration, so it's no change to the end
user experience.

Work on googleforgames#1799
@markmandel markmandel force-pushed the cleanup/admissionregistration-v1 branch from 68bcf34 to d96d485 Compare December 9, 2020 18:28
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e1503829-6007-4eaa-90a2-f5aaf4788360

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1919/head:pr_1919 && git checkout pr_1919
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-d96d485

@markmandel markmandel merged commit 712131a into googleforgames:master Dec 9, 2020
@markmandel markmandel deleted the cleanup/admissionregistration-v1 branch December 9, 2020 18:59
@markmandel markmandel added this to the 1.11.0 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XXL
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey