Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Scaling resource to v1betav1 to v1 #1920

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This includes extensions/v1beta1.Scale moving to autoscaling/v1.Scale.

Which issue(s) this PR fixes:

Work on #1799

Special notes for your reviewer:

The structure is the same, so there is no change for the end user.

This includes extensions/v1beta1.Scale moving to autoscaling/v1.Scale.

Work on googleforgames#1799
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 25ae3bfa-5a26-4725-b4cc-e3d2e1788675

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1920/head:pr_1920 && git checkout pr_1920
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-9be7239

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit e7a5b7d into googleforgames:master Dec 9, 2020
@markmandel markmandel added this to the 1.11.0 milestone Dec 9, 2020
@markmandel markmandel deleted the cleanup/scale-v1 branch December 9, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants