Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oops, k8s-api shortcode only pointed at one URL #1924

Merged
merged 2 commits into from
Dec 9, 2020

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Apparently forgot to take into account the href attribute on the shortcode, which was silly 🤦

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Apparently forgot to take into account the `href` attribute on the
shortcode, which was silly 🤦
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 57964030-9578-469f-8912-52b8ebcbe017

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1924/head:pr_1924 && git checkout pr_1924
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-9233995

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d0f2f7b7-5b45-4c7b-8cd8-b523d83488b7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1924/head:pr_1924 && git checkout pr_1924
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-c812ae3

@markmandel markmandel merged commit 1c244ab into googleforgames:master Dec 9, 2020
@markmandel markmandel deleted the bug/k8s-api branch December 9, 2020 23:09
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants