Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling to review pprof heaps #1927

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Adding an extra make target to make it easy to review heaps when doing long running tests on Agones, where you want to review the heap profile.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:
N/A

Adding an extra make target to make it easy to review heaps when doing
long running tests on Agones, where you want to review the heap profile.
@markmandel markmandel added kind/feature New features for Agones area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Dec 10, 2020
@google-cla google-cla bot added the cla: yes label Dec 10, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e6003781-5fb9-45a7-8150-25b7c0ea46bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1927/head:pr_1927 && git checkout pr_1927
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-ecea293

@markmandel
Copy link
Member Author

@ilkercelikyilmaz I feel like you will appreciate this 😄

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 156582c into googleforgames:master Dec 11, 2020
@markmandel markmandel deleted the build/add-heap-review branch December 11, 2020 17:55
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/feature New features for Agones lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants