Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectMeta should use additionalProperties #1949

Merged
merged 2 commits into from
Jan 16, 2021
Merged

ObjectMeta should use additionalProperties #1949

merged 2 commits into from
Jan 16, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Rather than using x-kubernetes-preserve-unknown-fields which allows both keys and values of any type, we should use additionalProperties which only allows a specified type (in this case "string") for keys and values.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Better validation!

Also matches ObjectMeta's actual OpenAPI v2 spec.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jan 14, 2021
@google-cla google-cla bot added the cla: yes label Jan 14, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 052f2d47-49b5-4e6c-a761-48c8ebc79ed9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
ObjectMeta should use additionalProperties
07aa310 
Rather than using `x-kubernetes-preserve-unknown-fields` which allows
both keys and values of any type, we should use `additionalProperties`
which only allows a specified type (in this case "string") for keys and
values.

Better validation!
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 49af6f31-d26a-4863-84c4-6a1731dd294c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1949/head:pr_1949 && git checkout pr_1949
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-07aa310

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 58ec637a-27ae-4d0f-8dc1-8a13009fc7e2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1949/head:pr_1949 && git checkout pr_1949
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-bf8a69f

@roberthbailey roberthbailey merged commit 93d8c10 into googleforgames:master Jan 16, 2021
@markmandel markmandel deleted the cleanup/crd-metadata branch January 16, 2021 16:27
@markmandel markmandel added this to the 1.12.0 milestone Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey