Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ContainerPortAllocation to Stable #1961

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Move ContainerPortAllocation to Stable #1961

merged 1 commit into from
Jan 22, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

Remove the ContainerPortAllocation feature flag and previous code, and update the documentation to match.

Which issue(s) this PR fixes:

Closes #1773

Special notes for your reviewer:

@markmandel
Move ContainerPortAllocation to Stable
8fd1790 
Remove the `ContainerPortAllocation` feature flag and previous code, and
update the documentation to match.

Closes googleforgames#1773
@markmandel markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jan 22, 2021
@google-cla google-cla bot added the cla: yes label Jan 22, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1fe0ac9b-c302-4e96-af8b-cdbbf57d13e9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1961/head:pr_1961 && git checkout pr_1961
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-8fd1790

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 7488d80 into googleforgames:master Jan 22, 2021
@markmandel markmandel deleted the stable/ContainerPortAllocation branch January 22, 2021 15:09
@markmandel markmandel added this to the 1.12.0 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc cla: yes kind/feature New features for Agones lgtm size/XXL
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Move "Port Allocations to Multiple Containers" > Stable
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey