Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Minikube #1973 #1974

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Fix Minikube #1973 #1974

merged 2 commits into from
Feb 2, 2021

Conversation

rolfedh
Copy link
Collaborator

@rolfedh rolfedh commented Feb 1, 2021

Updated content to the issue I described in #1973

What type of PR is this?

documentation

What this PR does / Why we need it:

Improves the content. Helps users avoid error messages.

Which issue(s) this PR fixes:

Closes #1973

Special notes for your reviewer:

@google-cla
Copy link

google-cla bot commented Feb 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rolfedh
Copy link
Collaborator Author

rolfedh commented Feb 1, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 1, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: be7e5cf0-67be-4318-be2e-7677be59f0b9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1974/head:pr_1974 && git checkout pr_1974
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-08aa1b9

@rolfedh
Copy link
Collaborator Author

rolfedh commented Feb 1, 2021

/assign @cyriltovena

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes! I remember running into the same thing a while ago, and forgot to update the docs.

Thanks!

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, rolfedh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, rolfedh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4480db44-6338-489a-a37c-85f57f6744ad

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1974/head:pr_1974 && git checkout pr_1974
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-d90ed38

@markmandel markmandel merged commit 3cf898a into googleforgames:master Feb 2, 2021
@markmandel markmandel added this to the 1.12.0 milestone Feb 2, 2021
@markmandel markmandel added kind/documentation Documentation for Agones kind/bug These are bugs. labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minikube
5 participants