Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badly formatted feature tags in GameServer specification docs #1975

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

edmundlam
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Fixes some template syntax issues. Was reading the live documentation and came across the following rendering issue (see screenshot)

image

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@edmundlam
Copy link
Contributor Author

edmundlam commented Feb 1, 2021

Poking @markmandel because I think he's the one who added the doc changes

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 609ea8fc-ddbb-4835-b4a9-f521560726b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1975/head:pr_1975 && git checkout pr_1975
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-89f9a15

@roberthbailey
Copy link
Member

Wow that's ugly. Thanks for fixing it.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edmundlam, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 545cfba into googleforgames:master Feb 1, 2021
@markmandel markmandel added this to the 1.12.0 milestone Feb 2, 2021
@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants