Preparation for 1.13.0

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind release

What this PR does / Why we need it:

Getting ready for the next sprint 🏃

Which issue(s) this PR fixes:

Work on #1977

Special notes for your reviewer:

N/A

[agones-bot]

Build Failed 😱

Build Id: 6ceb91c5-3c5f-4f10-a6fb-5be98e28b243

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: c50cdf40-c587-496c-95bc-c7660434e608

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 230f2012-09f8-41ac-bf6d-9ecba86af2a4

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

From the error logs:

Attempting lock acquisition
Starting handler

installing current release
# if IMAGE_PULL_SECRET_FILE is specified, create the agones-system namespace and install the secret
\
	helm upgrade --install --wait --namespace=agones-system \
	--create-namespace \
	--set agones.image.tag=1.13.0-583a3fd,agones.image.registry=gcr.io/agones-images \
	--set agones.image.controller.pullPolicy="Always",agones.image.sdk.alwaysPull=true \
	--set agones.image.controller.pullSecret= \
	--set agones.ping.http.serviceType="LoadBalancer",agones.ping.udp.serviceType="LoadBalancer" \
	--set agones.allocator.http.serviceType="LoadBalancer" \
	--set agones.controller.logLevel="debug" \
	--set agones.crds.cleanupOnDelete=true \
	--set agones.featureGates="" \
	--set agones.allocator.http.loadBalancerIP=35.230.49.39 \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Error: UPGRADE FAILED: another operation (install/upgrade/rollback) is in progress
make: *** [install] Error 1
Makefile:319: recipe for target 'install' failed
Error running handler: exit status 2
Child terminated, releasing lock

What I don't understand is what the lock acquisition is for. If we have a mutex, shouldn't it prevent us from trying to run a helm upgrade while another is already in progress?

[agones-bot]

Build Failed 😱

Build Id: fdaeb95e-ccd7-4082-b91d-441f56158af7

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markmandel]

Having a look at the helm / cluster details, I see:

markmandel@cloudshell:~ (agones-images)$ helm ls -a --all-namespaces
NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART           APP VERSION
agones  agones-system   1               2021-02-03 04:16:45.526450117 +0000 UTC pending-install agones-1.12.0   1.12.0
consul  default         1               2020-11-17 19:23:42.564280953 +0000 UTC deployed        consul-3.9.6    1.5.3

I think that helm actually doesn't rollback a failed release automatically. I've had to go in a few times now and delete the helm installation when it a failed install occurs, so that it could then be subsequently installed over.

I think the answer is to add:

--atomic                       if set, upgrade process rolls back changes made in case of failed upgrade. The --wait flag will be set automatically if --atomic is used

To our helm install/upgrade command.

I'll add the command in a PR shortly, and we'll see how that goes. For now, deleting the helm install on the e2e cluster again.

[agones-bot]

Build Succeeded 👏

Build Id: 69090c5c-b2fa-4ac8-9afe-276516ccad56

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.13.0-583a3fd
• image: gcr.io/agones-images/agones-sdk:1.13.0-583a3fd
• image: gcr.io/agones-images/agones-ping:1.13.0-583a3fd
• Linux C++ SDK (build): agonessdk-1.13.0-583a3fd-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.13.0-583a3fd.zip

A preview of the website (the last 30 builds are retained):

• https://583a3fd-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1979/head:pr_1979 && git checkout pr_1979
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-583a3fd