Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Rust SDK Target folder #1985

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Rust builds will make a ./target folder, which should be ignored.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Rust builds will make a ./target folder, which should be ignored.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 9, 2021
@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bd9dee3f-46b4-4fd5-a9d7-4eb13d52f3bb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1985/head:pr_1985 && git checkout pr_1985
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-397487f

@markmandel markmandel requested review from pooneh-m and roberthbailey and removed request for cyriltovena and dzlier-gcp February 9, 2021 15:23
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 958f22ec-1001-40d6-86f9-7ffb1836180a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c978045c-ff76-4c87-86be-456dfc25f495

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1985/head:pr_1985 && git checkout pr_1985
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-e205793

@markmandel markmandel merged commit 976203e into googleforgames:main Feb 9, 2021
@markmandel markmandel added this to the 1.13.0 milestone Feb 9, 2021
@markmandel markmandel deleted the cleanup/ignore-target branch February 9, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants