Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade crd-client example #1986

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Upgrade crd-client example #1986

merged 1 commit into from
Feb 9, 2021

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Upgraded crd-client example to use Agones 1.12.0 and client-go for Kubernetes 1.17

Which issue(s) this PR fixes:

Closes #1982

Special notes for your reviewer:

Took the opportunity to update the alpine image as well.

@markmandel
Upgrade crd-client example
302c3d2 
Upgraded crd-client example to use Agones 1.12.0 and client-go for
Kubernetes 1.17

Closes googleforgames#1982
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Feb 9, 2021
@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1542d763-a506-4d51-8036-f8a9c724a336

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1986/head:pr_1986 && git checkout pr_1986
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-302c3d2

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 6ed4437 into googleforgames:main Feb 9, 2021
@markmandel markmandel deleted the upgrade/crd-client-1.12.0 branch February 9, 2021 15:22
@markmandel markmandel added this to the 1.13.0 milestone Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved area/examples Examples. Usually found in the `examples` directory cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/L
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Example from Access Agones via Kubernetes API failing to compile
4 participants
@markmandel @agones-bot @google-oss-robot @roberthbailey