Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "gke" prefix to TCP e2e firewall #1991

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Make sure we have the prefix of "gke" on the TCP firewall for the e2e cluster.

Keeps things consistent.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Make sure we have the prefix of "gke" on the TCP firewall for the e2e
cluster.

Keeps things consistent.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/operations Installation, updating, metrics etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Feb 10, 2021
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 359a7954-7927-4a60-b6de-be60944b2c34

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1991/head:pr_1991 && git checkout pr_1991
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-dae9f1c

@markmandel markmandel requested review from pooneh-m and roberthbailey and removed request for EricFortin and aLekSer February 10, 2021 22:00
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have any negative side-effects if you run helm upgrade? For fresh installs this doesn't concern me.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member Author

This only affects Terraform, and only on the e2e infrastructure, so no impact on Helm!

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fda38cc9-9cb8-4cf3-b4d2-7c6b3e48e24a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1991/head:pr_1991 && git checkout pr_1991
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-9e885b7

@markmandel markmandel merged commit d48b1c0 into googleforgames:main Feb 10, 2021
@markmandel markmandel deleted the e2e/firewall-name branch February 10, 2021 23:02
@markmandel markmandel added this to the 1.13.0 milestone Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/operations Installation, updating, metrics etc area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants