-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "gke" prefix to TCP e2e firewall #1991
Conversation
Make sure we have the prefix of "gke" on the TCP firewall for the e2e cluster. Keeps things consistent.
Build Succeeded 👏 Build Id: 359a7954-7927-4a60-b6de-be60944b2c34 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have any negative side-effects if you run helm upgrade? For fresh installs this doesn't concern me.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This only affects Terraform, and only on the e2e infrastructure, so no impact on Helm! |
New changes are detected. LGTM label has been removed. |
Build Succeeded 👏 Build Id: fda38cc9-9cb8-4cf3-b4d2-7c6b3e48e24a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Make sure we have the prefix of "gke" on the TCP firewall for the e2e cluster.
Keeps things consistent.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A