Update to PodTemplateSpec for 1.18 #2007
Conversation
|
Build Failed 😱 Build Id: 4b7ca39a-ebec-4b8c-9b75-a73ed0787806 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
So we can reproduce this sort of change in the future, can you document how you generated the helm change? |
What does this mean for us explaining how to upgrade to the next agones version? It sounds like helm update will fail... |
Good call. I added the
Good point. I'm going to add a warning on this page on the website in this PR, since it's related. |
Regenerated the PodTemplateSpec from Kubernetes OpenAPI endpoints. Most changes where description fields, with the exception of one new data field. Work on googleforgames#1971
- Warning on the website on Helm upgrade
markmandel
force-pushed
the
update/1.18-crd-spec
branch
from
22b7c5c
to
624e4fd
Compare
|
Added a warning on the upgrade page. It's something that can happen with the current Agones version, so I didn't wrap it in a |
|
Build Failed 😱 Build Id: 8b912dc1-9ac9-43bc-b59f-c43792d618a0 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 2a2be079-6406-444c-81f4-f14c492381c7 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 41a69faa-7106-4161-ace1-d1ae9e8e551f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Regenerated the PodTemplateSpec from Kubernetes OpenAPI endpoints.
Most changes where description fields, with the exception of one new data field.
Which issue(s) this PR fixes:
Work on #1971
Special notes for your reviewer:
Local testing indicates that Helm will try and patch the CRD changes and fail (which it now on CRD change, see helm/helm#5806 for more details).
I will likely have to handhold the testing, and delete helm installs during e2e tests where the CRDs need updating.
Apparently this gets fixed in later Helm+K8s combos, according to the above linked ticket 🤷♂️ but we will see.