Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whoops! Websocket documentation should be hidden #2015

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Missed a 1.3.0 that should have been a 1.13.0 on a {{% feature ... %}} on PR review 🤦

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Missed a `1.3.0` that should have been a `1.13.0` on a
`{{% feature ... %}}` on PR review 🤦
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 28bbf5c6-1f02-4178-8786-5e54e931b06a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f044b7c5-55ab-415a-bb0a-b4b0052ecd56

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2015/head:pr_2015 && git checkout pr_2015
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-cd72630

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@pooneh-m
Copy link
Contributor

pooneh-m commented Mar 3, 2021

Great catch!

@markmandel
Copy link
Member Author

Great catch!

Thanks to people on Slack! 😄

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e622c367-3eef-4440-8497-7ba171907ad8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2015/head:pr_2015 && git checkout pr_2015
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-bfe2d58

@markmandel markmandel merged commit c11186e into googleforgames:main Mar 3, 2021
@markmandel markmandel added this to the 1.13.0 milestone Mar 3, 2021
@markmandel markmandel deleted the bug/websocket-docks branch March 4, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants