Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a link to the website. #2017

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Fix a broken link.

Special notes for your reviewer:

https://agones.dev/site/docs/advanced/allocator-service returns a 404. https://agones.dev/site/docs/advanced/allocator-service/ takes us to the correct page.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member

This will likely fail e2e, just because I'm updating the default nodepool. Just a heads up.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f8143f17-9c63-4329-86c6-66bd514fd771

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: dbbdf1fd-f4a7-4e17-adaf-48bb3876f9b5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f108bce7-8553-41e0-83cb-1c20a5af950f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 81ac7d23-659a-4461-b1ef-c2e473b115e5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: df84031e-fdf3-4dee-a684-2a420d53c2e7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6ed6c66c-c4cd-41a1-b493-da1230adac08

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2017/head:pr_2017 && git checkout pr_2017
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-2acbb11

@markmandel markmandel merged commit bc192cd into googleforgames:main Mar 9, 2021
@markmandel markmandel added this to the 1.13.0 milestone Mar 9, 2021
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Mar 10, 2021
@roberthbailey roberthbailey deleted the load-grpc branch March 29, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants