Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to Allocator Service APIs #2023

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Conversation

jhowcrof
Copy link
Contributor

/kind documentation

What this PR does / Why we need it:
The gRPC API is defined in a proto and the REST API has a swagger.json file. Since the API differs slightly from the GameServerAllocation CRD, these links are pretty helpful for using the service.

Add tip about passing data using metaPatch.

The gRPC API is defined in a proto and the REST API has a swagger.json file. Since the API differs slightly from the GameServerAllocation CRD, these links are pretty helpful for using the service.

Add tip about passing data using metaPatch.
@markmandel
Copy link
Member

Assuming all passes, this LGTM. @pooneh-m this is your area, any comments? 😄

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones labels Mar 10, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 6130595c-eb11-419f-9736-aa999ac7bcf2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

--- FAIL: TestGameServerAllocationPreferredSelection (381.00s)
    gameserverallocation_test.go:379: error waiting for fleet condition on fleet preferred-2bjwj
FAIL

That's a new flake. Retrying.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 85abae21-0114-4375-b12e-f0d1b7fb4ef3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2023/head:pr_2023 && git checkout pr_2023
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-23225a4

Copy link
Contributor

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the documentation.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhowcrof, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m merged commit d6b5881 into googleforgames:main Mar 11, 2021
@markmandel markmandel added this to the 1.13.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants