Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where did the TCP e2e test go? #2043

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Seems like this e2e test disappeared somewhere along the way.

Now it's back!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Seems like this e2e test disappeared somewhere along the way.

Now it's back!
@google-cla google-cla bot added the cla: yes label Apr 2, 2021
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc and removed size/S labels Apr 2, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 25fcd437-6124-456e-9a12-83fe6e17b2d1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2043/head:pr_2043 && git checkout pr_2043
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-ec17ee4

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit c6d1c0a into googleforgames:main Apr 2, 2021
@markmandel markmandel deleted the test/tcp-e2e branch April 2, 2021 21:07
@markmandel markmandel added this to the 1.14.0 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants