Add Terraform config for Windows clusters #2046

jeremyje · 2021-04-02T21:52:32Z

What type of PR is this?
/kind feature

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
This enhances the Agones Terraform module to support Windows clusters.

To enable Windows support via Terraform you'll need to use the windowsInitialNodeCount and optionally the windowsMachineType variables.

NOTE: If Windows support is enabled then IP aliasing will be turned on for the cluster as well.

Example HCL module usage:

module "agones" {
  source = "../modules/gke"
  cluster = {
    project                 = "your-project-name-here"
    zone                    = "us-central1-a"
    windowsInitialNodeCount = "2"
    windowsMachineType      = "e2-standard-8"
  }
}

Which issue(s) this PR fixes:
This is for issue #54.

Special notes for your reviewer:
I'm not sure how this module is used and the expectations. Also is there tests that need to run?

agones-bot · 2021-04-02T22:31:28Z

Build Succeeded 👏

Build Id: 803b7aed-f613-480b-9fee-e7db1da73da1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-4e7566e
image: gcr.io/agones-images/agones-ping:1.14.0-4e7566e
Linux C++ SDK (build): agonessdk-1.14.0-4e7566e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-4e7566e.zip

A preview of the website (the last 30 builds are retained):

https://4e7566e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2046/head:pr_2046 && git checkout pr_2046
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-4e7566e

install/terraform/modules/gke/variables.tf

install/terraform/modules/gke/cluster.tf

agones-bot · 2021-04-14T16:43:24Z

Build Failed 😱

Build Id: d012cafd-f5c6-4515-ba15-0dc486d2f7f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

jeremyje · 2021-04-14T16:51:54Z

/retest

roberthbailey · 2021-04-14T17:27:12Z

Helm upgrade failed:

helm upgrade --install --atomic --namespace=agones-system \
	--create-namespace \
	--set agones.image.tag=1.14.0-d4e2013,agones.image.registry=gcr.io/agones-images \
	--set agones.image.controller.pullPolicy="Always",agones.image.sdk.alwaysPull=true \
	--set agones.image.controller.pullSecret= \
	--set agones.ping.http.serviceType="LoadBalancer",agones.ping.udp.serviceType="LoadBalancer" \
	--set agones.allocator.http.serviceType="LoadBalancer" \
	--set agones.controller.logLevel="debug" \
	--set agones.crds.cleanupOnDelete=true \
	--set agones.featureGates="" \
	--set agones.allocator.http.loadBalancerIP=34.105.5.159 \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Handling connection for 8500
Error: UPGRADE FAILED: release agones failed, and has been rolled back due to atomic being set: cannot patch "fleets.agones.dev" with kind CustomResourceDefinition:  "" is invalid: patch: Invalid value: ...
make: *** [install] Error 1
Makefile:324: recipe for target 'install' failed

roberthbailey · 2021-04-14T17:27:34Z

Re-trying to see if the e2e cluster is borked.

google-oss-robot · 2021-04-14T17:27:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2021-04-14T17:41:54Z

Build Failed 😱

Build Id: 9c78d447-7a22-439f-bd2a-1aa3fd1ed1f3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-robot · 2021-04-14T23:08:05Z

New changes are detected. LGTM label has been removed.

agones-bot · 2021-04-14T23:23:22Z

Build Failed 😱

Build Id: d8074dd1-df80-4f2f-8491-0dfd85097234

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-04-14T23:39:44Z

Weird - getting issues with CRD patching. But there's been no updates to CRD for a while. Clearing the helm install and retrying the tests.

Error: UPGRADE FAILED: release agones failed, and has been rolled back due to atomic being set: cannot patch "fleets.agones.dev" with kind CustomResourceDefinition:  "" is invalid: patch: Invalid value: "map[metadata:map[labels:map[chart:agones-1.14.0-dev]] ....

agones-bot · 2021-04-14T23:56:09Z

Build Failed 😱

Build Id: 0ce6062e-7d05-42be-a1b8-0981aabcd8e3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-04-15T00:00:40Z

Ah I found it. A Namespace got stuck and a CRD got disconnected from Helm somehow. Cleaning it all up.

markmandel · 2021-04-15T00:06:10Z

I think this should be good now. Retrying.

agones-bot · 2021-04-15T00:52:51Z

Build Failed 😱

Build Id: 70c0e696-fa6f-4484-9492-ed9a4fbc3791

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-04-15T02:29:06Z

This time it errored out on the sdk conformance tests:

Could not run Allocate(): RpcFailure: 14-UNAVAILABLE Socket closed. Exiting!
includes/sdk.mk:145: recipe for target 'run-sdk-conformance-no-build' failed
make[2]: *** [run-sdk-conformance-no-build] Error 1
make[1]: *** [run-sdk-conformance-test] Error 2
includes/sdk.mk:152: recipe for target 'run-sdk-conformance-test' failed
make: *** [run-sdk-conformance-test-rust] Error 2
includes/sdk.mk:168: recipe for target 'run-sdk-conformance-test-rust' failed
includes/sdk.mk:88: recipe for target 'run-sdk-command' failed
make[3]: *** [run-sdk-command] Error 1

agones-bot · 2021-04-15T03:01:53Z

Build Failed 😱

Build Id: 6f61f9ca-ecc1-410e-ace0-b093c7bb3c4a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-04-15T17:59:06Z

Build Succeeded 👏

Build Id: bd6fcab4-a608-486c-b5be-24ee602e4b38

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-7742330
image: gcr.io/agones-images/agones-ping:1.14.0-7742330
Linux C++ SDK (build): agonessdk-1.14.0-7742330-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-7742330.zip

A preview of the website (the last 30 builds are retained):

https://7742330-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2046/head:pr_2046 && git checkout pr_2046
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-7742330

google-cla bot added the cla: yes label Apr 2, 2021

google-oss-robot requested review from dzlier-gcp and roberthbailey April 2, 2021 21:52

google-oss-robot added the size/M label Apr 2, 2021

roberthbailey self-assigned this Apr 2, 2021

roberthbailey reviewed Apr 3, 2021

View reviewed changes

install/terraform/modules/gke/variables.tf Outdated Show resolved Hide resolved

install/terraform/modules/gke/cluster.tf Outdated Show resolved Hide resolved

google-oss-robot added size/L and removed size/M labels Apr 14, 2021

roberthbailey approved these changes Apr 14, 2021

View reviewed changes

google-oss-robot added the lgtm label Apr 14, 2021

google-oss-robot added the approved label Apr 14, 2021

Add Terraform config for Windows clusters

0b43c77

google-oss-robot removed the lgtm label Apr 14, 2021

Merge branch 'main' into winterraform

7742330

markmandel merged commit 066e811 into googleforgames:main Apr 15, 2021

markmandel added this to the 1.14.0 milestone Apr 15, 2021

roberthbailey added area/operations Installation, updating, metrics etc kind/feature New features for Agones labels Apr 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Terraform config for Windows clusters #2046

Add Terraform config for Windows clusters #2046

jeremyje commented Apr 2, 2021 •

edited

Loading

agones-bot commented Apr 2, 2021

agones-bot commented Apr 14, 2021

jeremyje commented Apr 14, 2021

roberthbailey commented Apr 14, 2021

roberthbailey commented Apr 14, 2021

google-oss-robot commented Apr 14, 2021

agones-bot commented Apr 14, 2021

google-oss-robot commented Apr 14, 2021

agones-bot commented Apr 14, 2021

markmandel commented Apr 14, 2021

agones-bot commented Apr 14, 2021

markmandel commented Apr 15, 2021

markmandel commented Apr 15, 2021

agones-bot commented Apr 15, 2021

roberthbailey commented Apr 15, 2021

agones-bot commented Apr 15, 2021

agones-bot commented Apr 15, 2021

Add Terraform config for Windows clusters #2046

Add Terraform config for Windows clusters #2046

Conversation

jeremyje commented Apr 2, 2021 • edited Loading

agones-bot commented Apr 2, 2021

agones-bot commented Apr 14, 2021

jeremyje commented Apr 14, 2021

roberthbailey commented Apr 14, 2021

roberthbailey commented Apr 14, 2021

google-oss-robot commented Apr 14, 2021

agones-bot commented Apr 14, 2021

google-oss-robot commented Apr 14, 2021

agones-bot commented Apr 14, 2021

markmandel commented Apr 14, 2021

agones-bot commented Apr 14, 2021

markmandel commented Apr 15, 2021

markmandel commented Apr 15, 2021

agones-bot commented Apr 15, 2021

roberthbailey commented Apr 15, 2021

agones-bot commented Apr 15, 2021

agones-bot commented Apr 15, 2021

jeremyje commented Apr 2, 2021 •

edited

Loading