Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress the long shell command to test for a file existence so that #2072

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

roberthbailey
Copy link
Member

it is clearer that not having the file is not an error.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Build experience is a bit nicer.

Which issue(s) this PR fixes:
Closes #1039

Special notes for your reviewer:

Old and new output can be seen in #1039 (comment)

it is clearer that not having the file is not an error.
@roberthbailey roberthbailey added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Apr 22, 2021
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@roberthbailey
Copy link
Member Author

/assign @pooneh-m

@roberthbailey
Copy link
Member Author

This PR fits adheres to the list of acceptable changes during feature freeze.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fb756443-699c-4983-8552-ec4f31209699

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2072/head:pr_2072 && git checkout pr_2072
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-c9dae66

@roberthbailey roberthbailey merged commit 4e53278 into googleforgames:main Apr 22, 2021
@roberthbailey roberthbailey added this to the 1.14.0 milestone Apr 22, 2021
@roberthbailey roberthbailey deleted the build-warning branch September 23, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.sh is missing in go directory for SDK
3 participants