Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the consul helm chart to use HashiCorp's Official Helm Chart. #2150

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Update the consul helm chart to use HashiCorp's Official Helm Chart. #2150

merged 2 commits into from
Jun 23, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

https://github.com/helm/charts/tree/master/stable/consul says that the chart we were previously using is deprecated and redirects to HashiCorp's Official Helm Chart.

Which issue(s) this PR fixes:

Work on #2129

Special notes for your reviewer:

@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a924e068-39e4-40bc-b44b-cd64a4b205ee

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1f9839bf-cd61-45da-a75c-f2bdd091bb10

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fafc48ca-ddd7-4fe1-b0c5-77603e7a1d9e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2150/head:pr_2150 && git checkout pr_2150
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-2c4e9e7

@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Jun 23, 2021
@markmandel markmandel merged commit 5a29c91 into googleforgames:main Jun 23, 2021
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
@roberthbailey roberthbailey deleted the terraform-e2e-consul branch September 23, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

Assignees

@markmandel markmandel

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @google-oss-robot @markmandel