Upgrade client-go to v0.19.12 #2155

cindy52 · 2021-06-23T23:26:17Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Update vendored client-go to support Kubernets 1.19.0

Which issue(s) this PR fixes:

Part of issue #2129
Closes #1797

agones-bot · 2021-06-23T23:34:23Z

Build Failed 😱

Build Id: 039c1a36-cc94-4522-86c4-1e4f29c40f9c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-06-23T23:48:53Z

Build Failed 😱

Build Id: 5dbc24ee-8435-4f27-8559-f674e679e3ec

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2021-06-24T04:36:48Z

The lint test is failing:

Already have image: make-docker
mkdir -p ~/.kube/
mkdir -p /workspace/build//.gocache
mkdir -p /workspace/build//.config/gcloud
mkdir -p ~/.config/helm
mkdir -p ~/.cache/helm
/usr/bin/make ensure-image IMAGE_TAG=agones-build:39d4b5cd22 BUILD_TARGET=build-build-image
make[1]: Entering directory '/workspace/build'
make[1]: Leaving directory '/workspace/build'
docker run -t -e "TERM=xterm-256color" -e "GO111MODULE=on" --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build -w /go/src/agones.dev/agones  agones-build:39d4b5cd22 bash -c \
	"golangci-lint run ./examples/... && golangci-lint run --timeout 15m ./..."
WARN [runner] Can't run linter goanalysis_metalinter: bodyclose: failed prerequisites: [buildssa@agones.dev/agones/cmd/allocator [agones.dev/agones/cmd/allocator.test]: analysis skipped: errors in package: [/go/src/agones.dev/agones/cmd/allocator/main.go:35:2: could not import agones.dev/agones/pkg/gameserverallocations (/go/src/agones.dev/agones/pkg/gameserverallocations/metrics.go:25:5: could not import agones.dev/agones/pkg/metrics (/go/src/agones.dev/agones/pkg/metrics/exporter.go:24:2: could not import contrib.go.opencensus.io/exporter/stackdriver (/go/src/agones.dev/agones/vendor/contrib.go.opencensus.io/exporter/stackdriver/stackdriver.go:57:11: could not import cloud.google.com/go/trace/apiv2 (/go/src/agones.dev/agones/vendor/cloud.google.com/go/trace/apiv2/trace_client.go:29:15: could not import google.golang.org/genproto/googleapis/devtools/cloudtrace/v2 (/go/src/agones.dev/agones/vendor/google.golang.org/genproto/googleapis/devtools/cloudtrace/v2/tracing.pb.go:257:12: ClientConnInterface not declared by package grpc))))) /go/src/agones.dev/agones/cmd/allocator/metrics.go:21:2: could not import agones.dev/agones/pkg/metrics (/go/src/agones.dev/agones/pkg/metrics/exporter.go:24:2: could not import contrib.go.opencensus.io/exporter/stackdriver (/go/src/agones.dev/agones/vendor/contrib.go.opencensus.io/exporter/stackdriver/stackdriver.go:57:11: could not import cloud.google.com/go/trace/apiv2 (/go/src/agones.dev/agones/vendor/cloud.google.com/go/trace/apiv2/trace_client.go:29:15: could not import google.golang.org/genproto/googleapis/devtools/cloudtrace/v2 (/go/src/agones.dev/agones/vendor/google.golang.org/genproto/googleapis/devtools/cloudtrace/v2/tracing.pb.go:257:12: ClientConnInterface not declared by package grpc))))]] 
WARN [runner] Can't run linter unused: buildir: failed to load package monitoring: could not load export data: no export data for "google.golang.org/genproto/googleapis/monitoring/v3" 
ERRO Running error: buildir: failed to load package monitoring: could not load export data: no export data for "google.golang.org/genproto/googleapis/monitoring/v3" 
Makefile:362: recipe for target 'lint' failed
make: *** [lint] Error 3

cindy52 · 2021-06-24T18:34:02Z

The lint test is failing:

Already have image: make-docker
mkdir -p ~/.kube/
mkdir -p /workspace/build//.gocache
mkdir -p /workspace/build//.config/gcloud
mkdir -p ~/.config/helm
mkdir -p ~/.cache/helm
/usr/bin/make ensure-image IMAGE_TAG=agones-build:39d4b5cd22 BUILD_TARGET=build-build-image
make[1]: Entering directory '/workspace/build'
make[1]: Leaving directory '/workspace/build'
docker run -t -e "TERM=xterm-256color" -e "GO111MODULE=on" --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build -w /go/src/agones.dev/agones  agones-build:39d4b5cd22 bash -c \
	"golangci-lint run ./examples/... && golangci-lint run --timeout 15m ./..."
WARN [runner] Can't run linter goanalysis_metalinter: bodyclose: failed prerequisites: [buildssa@agones.dev/agones/cmd/allocator [agones.dev/agones/cmd/allocator.test]: analysis skipped: errors in package: [/go/src/agones.dev/agones/cmd/allocator/main.go:35:2: could not import agones.dev/agones/pkg/gameserverallocations (/go/src/agones.dev/agones/pkg/gameserverallocations/metrics.go:25:5: could not import agones.dev/agones/pkg/metrics (/go/src/agones.dev/agones/pkg/metrics/exporter.go:24:2: could not import contrib.go.opencensus.io/exporter/stackdriver (/go/src/agones.dev/agones/vendor/contrib.go.opencensus.io/exporter/stackdriver/stackdriver.go:57:11: could not import cloud.google.com/go/trace/apiv2 (/go/src/agones.dev/agones/vendor/cloud.google.com/go/trace/apiv2/trace_client.go:29:15: could not import google.golang.org/genproto/googleapis/devtools/cloudtrace/v2 (/go/src/agones.dev/agones/vendor/google.golang.org/genproto/googleapis/devtools/cloudtrace/v2/tracing.pb.go:257:12: ClientConnInterface not declared by package grpc))))) /go/src/agones.dev/agones/cmd/allocator/metrics.go:21:2: could not import agones.dev/agones/pkg/metrics (/go/src/agones.dev/agones/pkg/metrics/exporter.go:24:2: could not import contrib.go.opencensus.io/exporter/stackdriver (/go/src/agones.dev/agones/vendor/contrib.go.opencensus.io/exporter/stackdriver/stackdriver.go:57:11: could not import cloud.google.com/go/trace/apiv2 (/go/src/agones.dev/agones/vendor/cloud.google.com/go/trace/apiv2/trace_client.go:29:15: could not import google.golang.org/genproto/googleapis/devtools/cloudtrace/v2 (/go/src/agones.dev/agones/vendor/google.golang.org/genproto/googleapis/devtools/cloudtrace/v2/tracing.pb.go:257:12: ClientConnInterface not declared by package grpc))))]] 
WARN [runner] Can't run linter unused: buildir: failed to load package monitoring: could not load export data: no export data for "google.golang.org/genproto/googleapis/monitoring/v3" 
ERRO Running error: buildir: failed to load package monitoring: could not load export data: no export data for "google.golang.org/genproto/googleapis/monitoring/v3" 
Makefile:362: recipe for target 'lint' failed
make: *** [lint] Error 3

Saw it. It related to the old grpc package. Fixing it now.

agones-bot · 2021-06-24T19:37:53Z

Build Succeeded 👏

Build Id: 1abbc16a-02e8-4336-84ec-880a46ff5ddd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-ea89d4a
image: gcr.io/agones-images/agones-ping:1.16.0-ea89d4a
Linux C++ SDK (build): agonessdk-1.16.0-ea89d4a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-ea89d4a.zip

A preview of the website (the last 30 builds are retained):

https://ea89d4a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2155/head:pr_2155 && git checkout pr_2155
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-ea89d4a

agones-bot · 2021-06-24T19:48:45Z

Build Succeeded 👏

Build Id: 5d11d912-28ac-41f9-96fa-764842ad2bfb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-dc4a67a
image: gcr.io/agones-images/agones-ping:1.16.0-dc4a67a
Linux C++ SDK (build): agonessdk-1.16.0-dc4a67a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-dc4a67a.zip

A preview of the website (the last 30 builds are retained):

https://dc4a67a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2155/head:pr_2155 && git checkout pr_2155
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-dc4a67a

cindy52 · 2021-06-24T19:49:42Z

/assign @roberthbailey

google-oss-robot · 2021-06-24T21:22:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cindy52, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-cla bot added the cla: yes label Jun 23, 2021

google-oss-robot requested review from pooneh-m and roberthbailey June 23, 2021 23:26

google-oss-robot added the size/XXL label Jun 23, 2021

Upgrade client-go to v0.19.12

dc4a67a

google-oss-robot assigned roberthbailey Jun 24, 2021

roberthbailey added the kind/breaking Breaking change label Jun 24, 2021

roberthbailey approved these changes Jun 24, 2021

View reviewed changes

google-oss-robot added the lgtm label Jun 24, 2021

roberthbailey merged commit 75db964 into googleforgames:main Jun 24, 2021

google-oss-robot added the approved label Jun 24, 2021

roberthbailey added this to the 1.16.0 milestone Jul 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade client-go to v0.19.12 #2155

Upgrade client-go to v0.19.12 #2155

cindy52 commented Jun 23, 2021 •

edited

Loading

agones-bot commented Jun 23, 2021

agones-bot commented Jun 23, 2021

roberthbailey commented Jun 24, 2021

cindy52 commented Jun 24, 2021

agones-bot commented Jun 24, 2021

agones-bot commented Jun 24, 2021

cindy52 commented Jun 24, 2021

google-oss-robot commented Jun 24, 2021

Upgrade client-go to v0.19.12 #2155

Upgrade client-go to v0.19.12 #2155

Conversation

cindy52 commented Jun 23, 2021 • edited Loading

agones-bot commented Jun 23, 2021

agones-bot commented Jun 23, 2021

roberthbailey commented Jun 24, 2021

cindy52 commented Jun 24, 2021

agones-bot commented Jun 24, 2021

agones-bot commented Jun 24, 2021

cindy52 commented Jun 24, 2021

google-oss-robot commented Jun 24, 2021

cindy52 commented Jun 23, 2021 •

edited

Loading