Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CRD API reference and regenerate CRD Kubernetes client libraries for Kubernetes 1.19. #2158

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Update CRD API reference and regenerate CRD Kubernetes client libraries for Kubernetes 1.19. #2158

merged 1 commit into from
Jun 26, 2021

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

  • Manually edited crd-doc-config.json to point docs to the new k8s
    version.
  • Ran make gen-crd-client

Which issue(s) this PR fixes:

Part of #2129

Special notes for your reviewer:

@google-cla google-cla bot added the cla: yes label Jun 24, 2021
@roberthbailey roberthbailey changed the title Update CRD API reference for Kubernetes 1.19. Update CRD API reference and regenerate CRD Kubernetes client libraries for Kubernetes 1.19. Jun 24, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 31516a9c-3a86-4998-8ada-e56322949438

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2158/head:pr_2158 && git checkout pr_2158
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-f3fd10b

@roberthbailey
Update CRD API reference for Kubernetes 1.19.
7c5ee02 
- Manually edited crd-doc-config.json to point docs to the new k8s
version.
- Ran `make gen-crd-client`
markmandel
markmandel approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 095a2de9-0368-4a00-9fca-27fdcf0e6569

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 63dbd9c8-f8a8-4e83-b17e-04799631c9a9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2158/head:pr_2158 && git checkout pr_2158
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-7c5ee02

@roberthbailey roberthbailey merged commit 2d135a8 into googleforgames:main Jun 26, 2021
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
@roberthbailey roberthbailey added area/operations Installation, updating, metrics etc kind/documentation Documentation for Agones labels Jul 13, 2021
@roberthbailey roberthbailey deleted the crd-spec-1.19 branch September 23, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@markmandel markmandel

Labels
approved area/operations Installation, updating, metrics etc cla: yes kind/documentation Documentation for Agones lgtm size/XXL
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @google-oss-robot @markmandel