Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/go 1.15 #2167

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Upgrade/go 1.15 #2167

merged 2 commits into from
Jul 2, 2021

Conversation

cindy52
Copy link
Contributor

@cindy52 cindy52 commented Jul 1, 2021

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Upgrade go version to 1.15.13 Go 1.15 no longer supports Common Name based certs for HTTPS without a specific flag. This PR includes adding SAN for all related certs and updating the doc to create a cert with SAN for allocation service.

Which issue(s) this PR fixes:

Closes #1899
Closes #2024

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b03120d1-ce7b-4e6a-87bb-fc3474de97cd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2167/head:pr_2167 && git checkout pr_2167
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-1f4ea3a

@cindy52
Copy link
Contributor Author

cindy52 commented Jul 1, 2021

@markmandel , I upgraded to go 1.15 instead and create another issue #2168 to address gen-api-docs failing. Since go 1.15 will require SAN for certs as well, thinking it might be good to check in the adding SAN change and later fix the gen-api-docs issue.

@markmandel
Copy link
Member

@markmandel , I upgraded to go 1.15 instead and create another issue #2168 to address gen-api-docs failing. Since go 1.15 will require SAN for certs as well, thinking it might be good to check in the adding SAN change and later fix the gen-api-docs issue.

Makes sense to me 👍🏻

build/build-image/Dockerfile Show resolved Hide resolved
@@ -96,6 +96,9 @@ EOF
# Add ca.crt to the allocator-tls-ca Secret
TLS_CA_VALUE=$(kubectl get secret allocator-tls -n agones-system -ojsonpath='{.data.ca\.crt}')
kubectl get secret allocator-tls-ca -o json -n agones-system | jq '.data["tls-ca.crt"]="'${TLS_CA_VALUE}'"' | kubectl apply -f -
echo $TLS_CA_VALUE | base64 -d > ca.crt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes only necessary once we make the next release (and are using go 1.15)? If so, they should be behind a feature gate: https://agones.dev/site/docs/contribute/#within-a-page

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they need to go behind a feature gate, as they will still work with the current release - and if people do it now, they don't have to do it later. So no issue as it is on my end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as they work with both old and new versions, sgtm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.15 no longer supports Common Name based certs for HTTPS without a specific flag. Adding SAN to the cert is the solution and it's also backward compatible.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cindy52, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 3756583 into googleforgames:main Jul 2, 2021
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
@roberthbailey roberthbailey added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/breaking Breaking change labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/breaking Breaking change lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run Allocation example with Go 1.16 Migrate to using SANs for webhook certificates for Go 1.15
5 participants