Custom fleet autoscaler resync interval #2171

jie-bao · 2021-07-07T05:57:19Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:
Add a new property sync to FleetAutoScaler for supporting custom sync interval.
See more details in: #1955

Which issue(s) this PR fixes:

Closes #1955

Special notes for your reviewer:
None

agones-bot · 2021-07-07T06:06:14Z

Build Failed 😱

Build Id: 3b54a562-568d-460e-bb3d-352d190c3a1c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-07-07T06:08:41Z

Build Failed 😱

Build Id: 5dcdd297-bcef-480b-a43b-96bec6376f04

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-07-07T06:45:58Z

Build Failed 😱

Build Id: d950e74b-3b09-47b5-b931-cefd25b734b3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

steven-supersolid

Just approving the package-lock.json change which is unrelated but at least syncs package-lock and package again :)

markmandel · 2021-07-08T00:09:22Z

Handholding testing, because change in CRDs. (I can't wait until this gets fixed), and restarting tests!

agones-bot · 2021-07-08T00:28:22Z

Build Failed 😱

Build Id: def1f3c2-5347-41cf-b966-580d6432ca59

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-07-08T05:49:19Z

Build Failed 😱

Build Id: 826e136c-0548-4f9f-bec9-437e4d5b4063

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

jie-bao · 2021-07-08T05:52:41Z

Handholding testing, because change in CRDs. (I can't wait until this gets fixed), and restarting tests!

Sorry, I found a bug and fixed it. But the CI is blocked on the e2e-stable again. Is there a way I can work around it by myself?

agones-bot · 2021-07-08T17:38:13Z

Build Failed 😱

Build Id: 0eb30eaa-b0a7-43e1-9bdb-61a010b31784

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-07-08T17:42:02Z

Huh, that's odd. I removed the helm install. I'll do it again.

I wish there was a way for you to fix things (or for it not to be a problem, but I'll handhold it through).

agones-bot · 2021-07-08T18:08:50Z

Build Failed 😱

Build Id: 4ceac768-a542-49cf-96b9-8dc4add0c933

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-07-08T18:30:43Z

--- FAIL: TestAutoscalerBasicFunctions (408.14s)
    fleetautoscaler_test.go:103: error waiting for fleet condition on fleet simple-fleet-qctp9
FAIL
time="2021-07-08 18:08:45.322" level=info msg="Namespace 1625767270 is deleted"
FAIL	agones.dev/agones/test/e2e	454.668s
FAIL
make[1]: *** [test-e2e-integration] Error 1
Makefile:273: recipe for target 'test-e2e-integration' failed
make[1]: Leaving directory '/workspace/build'
Makefile:265: recipe for target 'test-e2e' failed
make: *** [test-e2e] Error 2

Seems like a legitimate failure, but I'll run it again for you, just so we can be sure 👍🏻

agones-bot · 2021-07-08T18:59:34Z

Build Failed 😱

Build Id: 13d3c2b5-fe1d-4f3b-b0a0-2f285c773e22

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-07-08T19:07:09Z

Nope, looks like a legit issue, same failure on e2e-feature-gates

--- FAIL: TestAutoscalerBasicFunctions (389.41s)
    fleetautoscaler_test.go:103: error waiting for fleet condition on fleet simple-fleet-mlq8d
FAIL
time="2021-07-08 18:58:56.791" level=info msg="Namespace 1625770241 is deleted"
FAIL	agones.dev/agones/test/e2e	495.298s
FAIL
Makefile:273: recipe for target 'test-e2e-integration' failed

udpate test case for fas sync interval rename interval to fixedInterval

agones-bot · 2021-08-02T04:06:32Z

Build Failed 😱

Build Id: 070e46c9-ce14-47f7-8239-38ce892112c6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-08-02T04:52:12Z

Build Failed 😱

Build Id: c14d9960-700f-4d7c-ba78-f6f1b624b18f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

jie-bao · 2021-08-02T12:48:03Z

Hi, above build failed. But it doesn't look like an issue involved by this PR. Could anyone help retry it?

roberthbailey · 2021-08-02T15:36:08Z

Here's the error:

Starting e2e integration test!
go test -mod=vendor -race -parallel=32 agones.dev/agones/test/e2e --kubeconfig /root/.kube/config \
	--gameserver-image=gcr.io/agones-images/simple-game-server:0.3 \
	--pullsecret= \
	--feature-gates="" \
	--namespace=""
time="2021-08-02 04:51:31.777" level=info msg="Starting e2e test(s)" featureGates="CustomFasSyncInterval=false&Example=true&NodeExternalDNS=false&PlayerAllocationFilter=false&PlayerTracking=false&RollingUpdateOnReady=true&SDKWatchSendOnExecute=true&StateAllocationFilter=false" gameServerImage="gcr.io/agones-images/simple-game-server:0.3" namespace= perfOutputDir= pullSecret= stressTestLevel=0 version=
time="2021-08-02 04:51:31.849" level=info msg="cause for namespace deletion error" reason=NotFound
time="2021-08-02 04:51:31.849" level=error msg="failed to cleanup e2e namespaces" error="namespaces \"1627879575\" not found"
FAIL	agones.dev/agones/test/e2e	0.159s
FAIL
Makefile:273: recipe for target 'test-e2e-integration' failed

roberthbailey · 2021-08-02T15:36:24Z

I restarted the test.

agones-bot · 2021-08-02T16:00:31Z

Build Succeeded 👏

Build Id: 9dbf9786-1aa4-44b1-9736-2908c5143fdd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-337a5f1
image: gcr.io/agones-images/agones-ping:1.17.0-337a5f1
Linux C++ SDK (build): agonessdk-1.17.0-337a5f1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-337a5f1.zip

A preview of the website (the last 30 builds are retained):

https://337a5f1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2171/head:pr_2171 && git checkout pr_2171
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-337a5f1

jie-bao · 2021-08-04T02:43:12Z

Hi @markmandel , could you take a look of this PR again? I think it might be ready :)

markmandel

Sorry about the delay! Just caught a minor documentation thing that i missed first time - but I think that is the last item!

site/content/en/docs/Reference/fleetautoscaler.md

Co-authored-by: Mark Mandel <markmandel@google.com>

agones-bot · 2021-08-09T02:18:10Z

Build Succeeded 👏

Build Id: b1aabd91-6f58-4088-8cae-4c72d87137d5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-5a23022
image: gcr.io/agones-images/agones-ping:1.17.0-5a23022
Linux C++ SDK (build): agonessdk-1.17.0-5a23022-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-5a23022.zip

A preview of the website (the last 30 builds are retained):

https://5a23022-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2171/head:pr_2171 && git checkout pr_2171
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-5a23022

markmandel · 2021-08-09T22:05:37Z

One final final thing (looks like I wasn't clear in my last comment)

The changes you made to the example yaml in site/content/en/docs/Reference/fleetautoscaler.md - add them into https://github.com/googleforgames/agones/blob/main/examples/fleet.yaml (it's basically the same thing content, just gives you two different ways to look at it) - that file is a full Fleet specification, so you can see all the options in a yaml file.

That's it. Once that's done, will approve and merge! 👍🏻 nice work!

agones-bot · 2021-08-10T02:17:51Z

Build Succeeded 👏

Build Id: 000cf049-61a2-47eb-b656-d2fa1be0d688

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-088a908
image: gcr.io/agones-images/agones-ping:1.17.0-088a908
Linux C++ SDK (build): agonessdk-1.17.0-088a908-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-088a908.zip

A preview of the website (the last 30 builds are retained):

https://088a908-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2171/head:pr_2171 && git checkout pr_2171
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-088a908

jie-bao · 2021-08-10T02:28:59Z

One final final thing (looks like I wasn't clear in my last comment)

The changes you made to the example yaml in site/content/en/docs/Reference/fleetautoscaler.md - add them into https://github.com/googleforgames/agones/blob/main/examples/fleet.yaml (it's basically the same thing content, just gives you two different ways to look at it) - that file is a full Fleet specification, so you can see all the options in a yaml file.

That's it. Once that's done, will approve and merge! 👍🏻 nice work!

I think you meant https://github.com/googleforgames/agones/blob/main/examples/fleetautoscaler.yaml since there's no FleetAutoScaler in fleet.yaml. I updated it.

agones-bot · 2021-08-10T02:49:37Z

Build Succeeded 👏

Build Id: e5a8b30b-6a2b-4633-84fe-edfacd5c060e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.17.0-4c88875
image: gcr.io/agones-images/agones-ping:1.17.0-4c88875
Linux C++ SDK (build): agonessdk-1.17.0-4c88875-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.17.0-4c88875.zip

A preview of the website (the last 30 builds are retained):

https://4c88875-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2171/head:pr_2171 && git checkout pr_2171
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.17.0-4c88875

markmandel

I think you meant https://github.com/googleforgames/agones/blob/main/examples/fleetautoscaler.yaml since there's no FleetAutoScaler in fleet.yaml. I updated it.

Yes! That's the one! 🥳

google-oss-robot · 2021-08-10T17:54:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jie-bao, markmandel, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot added the size/L label Jul 7, 2021

google-oss-robot requested review from cyriltovena and steven-supersolid July 7, 2021 05:57

google-cla bot added the cla: yes label Jul 7, 2021

jie-bao force-pushed the custom-fleet-autoscaler-resync-interval branch from 439ed18 to fc42eb2 Compare July 7, 2021 06:00

steven-supersolid approved these changes Jul 7, 2021

View reviewed changes

google-oss-robot assigned steven-supersolid Jul 7, 2021

google-oss-robot added the lgtm label Jul 7, 2021

markmandel mentioned this pull request Jul 8, 2021

Allow FILE env variable for local SDK server #2174

Merged

google-oss-robot removed the lgtm label Jul 8, 2021

Bao Jie added 7 commits July 9, 2021 19:19

add sync related parameters into fas api

b5d40c8

udpate test case for fas sync interval rename interval to fixedInterval

update crd

f0a1d85

update fas controller

bebf276

update fleetautoscaler spec in tests

e0d1cb2

add feature gate

e638415

add custom fas interval functions

baffbd5

Rename CustomFasRsyncInterval to CustomFasSyncInterval

df6818d

jie-bao force-pushed the custom-fleet-autoscaler-resync-interval branch from 2b4ff91 to c55a67c Compare August 2, 2021 03:45

google-oss-robot added size/XL and removed size/XXL labels Aug 2, 2021

Merge branch 'main' into custom-fleet-autoscaler-resync-interval

337a5f1

jie-bao requested a review from markmandel August 4, 2021 02:41

markmandel reviewed Aug 6, 2021

View reviewed changes

site/content/en/docs/Reference/fleetautoscaler.md Show resolved Hide resolved

Update site/content/en/docs/Reference/fleetautoscaler.md

5a23022

Co-authored-by: Mark Mandel <markmandel@google.com>

Merge branch 'main' into custom-fleet-autoscaler-resync-interval

088a908

add feature gate to fleetautoscaler example. update reference in doc

4c88875

markmandel approved these changes Aug 10, 2021

View reviewed changes

markmandel merged commit 0c1fd4f into googleforgames:main Aug 10, 2021

google-oss-robot assigned markmandel Aug 10, 2021

markmandel added this to the 1.17.0 milestone Aug 10, 2021

google-oss-robot added the lgtm label Aug 10, 2021

markmandel added the kind/feature New features for Agones label Aug 10, 2021

google-oss-robot added the approved label Aug 10, 2021

yoshd mentioned this pull request Aug 27, 2021

Fix validation bug in FleetAutoscaler #2242

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom fleet autoscaler resync interval #2171

Custom fleet autoscaler resync interval #2171

jie-bao commented Jul 7, 2021

agones-bot commented Jul 7, 2021

agones-bot commented Jul 7, 2021

agones-bot commented Jul 7, 2021

steven-supersolid left a comment

markmandel commented Jul 8, 2021

agones-bot commented Jul 8, 2021

agones-bot commented Jul 8, 2021

jie-bao commented Jul 8, 2021

agones-bot commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Aug 2, 2021

agones-bot commented Aug 2, 2021

jie-bao commented Aug 2, 2021

roberthbailey commented Aug 2, 2021

roberthbailey commented Aug 2, 2021

agones-bot commented Aug 2, 2021

jie-bao commented Aug 4, 2021

markmandel left a comment

agones-bot commented Aug 9, 2021

markmandel commented Aug 9, 2021 •

edited

Loading

agones-bot commented Aug 10, 2021

jie-bao commented Aug 10, 2021

agones-bot commented Aug 10, 2021

markmandel left a comment

google-oss-robot commented Aug 10, 2021

Custom fleet autoscaler resync interval #2171

Custom fleet autoscaler resync interval #2171

Conversation

jie-bao commented Jul 7, 2021

agones-bot commented Jul 7, 2021

agones-bot commented Jul 7, 2021

agones-bot commented Jul 7, 2021

steven-supersolid left a comment

Choose a reason for hiding this comment

markmandel commented Jul 8, 2021

agones-bot commented Jul 8, 2021

agones-bot commented Jul 8, 2021

jie-bao commented Jul 8, 2021

agones-bot commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Jul 8, 2021

markmandel commented Jul 8, 2021

agones-bot commented Aug 2, 2021

agones-bot commented Aug 2, 2021

jie-bao commented Aug 2, 2021

roberthbailey commented Aug 2, 2021

roberthbailey commented Aug 2, 2021

agones-bot commented Aug 2, 2021

jie-bao commented Aug 4, 2021

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Aug 9, 2021

markmandel commented Aug 9, 2021 • edited Loading

agones-bot commented Aug 10, 2021

jie-bao commented Aug 10, 2021

agones-bot commented Aug 10, 2021

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Aug 10, 2021

markmandel commented Aug 9, 2021 •

edited

Loading