Allow disabling of all allocator secrets in helm chart #2177

sudermanjr · 2021-07-09T15:53:19Z

Signed-off-by: Andrew Suderman andrew@sudermanjr.com

What type of PR is this?
/kind feature

What this PR does / Why we need it:
Provide a flag to completely disable allocator certificate generation

Which issue(s) this PR fixes:

Closes #2175

TODO:

Add documentation

agones-bot · 2021-07-09T16:16:26Z

Build Succeeded 👏

Build Id: 74b74d67-1fde-4e8a-974e-787eba50eae0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-edbfa8a
image: gcr.io/agones-images/agones-ping:1.16.0-edbfa8a
Linux C++ SDK (build): agonessdk-1.16.0-edbfa8a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-edbfa8a.zip

A preview of the website (the last 30 builds are retained):

https://edbfa8a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-edbfa8a

agones-bot · 2021-07-09T16:32:40Z

Build Succeeded 👏

Build Id: b4bd1e74-5b0c-428c-9024-c0e07fceaef5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-339801c
image: gcr.io/agones-images/agones-ping:1.16.0-339801c
Linux C++ SDK (build): agonessdk-1.16.0-339801c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-339801c.zip

A preview of the website (the last 30 builds are retained):

https://339801c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-339801c

agones-bot · 2021-07-09T16:43:05Z

Build Succeeded 👏

Build Id: 3ca45bad-6a3f-4428-8326-5037dfdaf730

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-250e19b
image: gcr.io/agones-images/agones-ping:1.16.0-250e19b
Linux C++ SDK (build): agonessdk-1.16.0-250e19b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-250e19b.zip

A preview of the website (the last 30 builds are retained):

https://250e19b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-250e19b

agones-bot · 2021-07-09T16:55:32Z

Build Succeeded 👏

Build Id: 7db121a5-7b88-4306-9fe0-e8aac41e6e7e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-cc2ea02
image: gcr.io/agones-images/agones-ping:1.16.0-cc2ea02
Linux C++ SDK (build): agonessdk-1.16.0-cc2ea02-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-cc2ea02.zip

A preview of the website (the last 30 builds are retained):

https://cc2ea02-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-cc2ea02

agones-bot · 2021-07-09T17:06:36Z

Build Succeeded 👏

Build Id: 662220df-7a24-4794-9fb8-91408bdaf2d2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-9c46efc
image: gcr.io/agones-images/agones-ping:1.16.0-9c46efc
Linux C++ SDK (build): agonessdk-1.16.0-9c46efc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-9c46efc.zip

A preview of the website (the last 30 builds are retained):

https://9c46efc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-9c46efc

roberthbailey · 2021-07-09T17:59:15Z

site/content/en/docs/Advanced/allocator-service.md

@@ -101,6 +101,10 @@ echo $TLS_CA_VALUE | base64 -d > ca.crt
 # echo $TLS_CA_VALUE | base64 -D > ca.crt
 ```

+### Bring Your Own Certificates (advanced)
+
+If you would like to completely manage the tls secrets outside of helm, you can create them in the namespace where agones is going to be installed, and then set `agones.allocator.disableSecretCreation` to `true`. This method will also work with the cert-manager method, as long as your certificate and secret are created ahead of time, and you populate the `allocator-tls-ca` and `allocator-client-ca` yourself.


nit: "set the helm parameter ... to true"

What happens during install if the secrets aren't already in place? Does the helm install fail? Or does the install succeed and agones is non functional?

If you don't set the wait or atomic flags when using helm, the installation will succeed and the allocator pods will fail to start.

site/content/en/docs/Advanced/allocator-service.md

agones-bot · 2021-07-09T18:23:14Z

Build Failed 😱

Build Id: 3513cf05-0a23-4c2b-bd34-e9fbb112cce4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-07-09T18:51:37Z

Build Succeeded 👏

Build Id: 0f3c228f-ad60-4d49-8022-7e97ce73fe9e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-51587ad
image: gcr.io/agones-images/agones-ping:1.16.0-51587ad
Linux C++ SDK (build): agonessdk-1.16.0-51587ad-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-51587ad.zip

A preview of the website (the last 30 builds are retained):

https://51587ad-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-51587ad

Signed-off-by: Andrew Suderman <andrew@sudermanjr.com>

agones-bot · 2021-07-09T21:53:47Z

Build Succeeded 👏

Build Id: c511c59d-09a0-4cf9-9770-2ca46cbabedd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-ff54faa
image: gcr.io/agones-images/agones-ping:1.16.0-ff54faa
Linux C++ SDK (build): agonessdk-1.16.0-ff54faa-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-ff54faa.zip

A preview of the website (the last 30 builds are retained):

https://ff54faa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-ff54faa

agones-bot · 2021-07-09T21:59:40Z

Build Succeeded 👏

Build Id: 59a706bd-cf5b-4802-adcd-3c243a51abb9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-8e4d7e8
image: gcr.io/agones-images/agones-ping:1.16.0-8e4d7e8
Linux C++ SDK (build): agonessdk-1.16.0-8e4d7e8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-8e4d7e8.zip

A preview of the website (the last 30 builds are retained):

https://8e4d7e8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-8e4d7e8

Signed-off-by: Andrew Suderman <andrew@sudermanjr.com>

agones-bot · 2021-07-12T15:51:27Z

Build Succeeded 👏

Build Id: 9f014b2e-5e8b-4911-9a5e-24e3b6231001

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-41c2828
image: gcr.io/agones-images/agones-ping:1.16.0-41c2828
Linux C++ SDK (build): agonessdk-1.16.0-41c2828-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-41c2828.zip

A preview of the website (the last 30 builds are retained):

https://41c2828-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2177/head:pr_2177 && git checkout pr_2177
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-41c2828

google-oss-robot · 2021-07-12T17:07:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, sudermanjr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot added the do-not-merge/work-in-progress label Jul 9, 2021

google-oss-robot requested review from aLekSer and EricFortin July 9, 2021 15:53

google-cla bot added the cla: yes label Jul 9, 2021

google-oss-robot added size/XS size/S and removed size/XS labels Jul 9, 2021

sudermanjr changed the title ~~Allow disabling of all allocator certificates~~ Allow disabling of all allocator certificates in helm chart Jul 9, 2021

sudermanjr changed the title ~~Allow disabling of all allocator certificates in helm chart~~ Allow disabling of all allocator secrets in helm chart Jul 9, 2021

sudermanjr marked this pull request as ready for review July 9, 2021 17:11

google-oss-robot removed the do-not-merge/work-in-progress label Jul 9, 2021

roberthbailey reviewed Jul 9, 2021

View reviewed changes

Allow disabling of all allocator certificates and secrets in helm chart

ff54faa

Signed-off-by: Andrew Suderman <andrew@sudermanjr.com>

fix helm table

41c2828

Signed-off-by: Andrew Suderman <andrew@sudermanjr.com>

roberthbailey approved these changes Jul 12, 2021

View reviewed changes

google-oss-robot assigned roberthbailey Jul 12, 2021

google-oss-robot added the lgtm label Jul 12, 2021

google-oss-robot added the approved label Jul 12, 2021

roberthbailey merged commit f1046e3 into googleforgames:main Jul 12, 2021

roberthbailey added this to the 1.16.0 milestone Jul 13, 2021

roberthbailey added kind/feature New features for Agones area/operations Installation, updating, metrics etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Jul 13, 2021

roberthbailey mentioned this pull request Sep 23, 2021

Helm chart: generateTLS=false uses certificates from the repository #1710

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow disabling of all allocator secrets in helm chart #2177

Allow disabling of all allocator secrets in helm chart #2177

sudermanjr commented Jul 9, 2021 •

edited

Loading

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

roberthbailey Jul 9, 2021

roberthbailey Jul 9, 2021

sudermanjr Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 12, 2021

google-oss-robot commented Jul 12, 2021

Allow disabling of all allocator secrets in helm chart #2177

Allow disabling of all allocator secrets in helm chart #2177

Conversation

sudermanjr commented Jul 9, 2021 • edited Loading

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

roberthbailey Jul 9, 2021

Choose a reason for hiding this comment

roberthbailey Jul 9, 2021

Choose a reason for hiding this comment

sudermanjr Jul 9, 2021

Choose a reason for hiding this comment

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 9, 2021

agones-bot commented Jul 12, 2021

google-oss-robot commented Jul 12, 2021

sudermanjr commented Jul 9, 2021 •

edited

Loading