Intercept Xonotic stdout for SDK Integration #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
the
area/examples
|
Build Failed 😱 Build Id: ae77ad29-b1c9-4fe5-a4ff-892c099b1530 Build Logs |
|
Build Failed 😱 Build Id: 61ae0bd9-e3fc-4e3b-a325-d3a9d9726145 Build Logs |
enocom
suggested changes
May 23, 2018
| ENTRYPOINT /home/xonotic/wrapper -i /home/xonotic/Xonotic/server_linux.sh |
There was a problem hiding this comment.
Small thing here: missing newline at end of file.
examples/xonotic/README.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| Example using a [Xonotic](http://www.xonotic.org) dedicated game server. | |||
|
|
|||
| *Note:* This example doesn't directly integrate the SDK (yet), but calls it via a separate binary. | |||
| This example wraps the Xonotic server with a [Go](https://golang.org) binary, and introspect | |||
There was a problem hiding this comment.
Short to "introspects stdout"?
examples/xonotic/README.md
Outdated
| This example wraps the Xonotic server with a [Go](https://golang.org) binary, and introspect | ||
| the stdout output to provide the event hooks for the SDK integration. | ||
|
|
||
| It is not a direct integration, but is a nice way of demoing an approach for to integrate with existing |
There was a problem hiding this comment.
an approach for integrating
| image: gcr.io/agones-images/xonotic-example:0.2 |
examples/xonotic/gameserver.yaml
Outdated
| @@ -23,5 +23,5 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: xonotic | |||
| image: gcr.io/agones-images/xonotic-example:0.1 | |||
| image: gcr.io/agones-images/xonotic-example:0.2 | |||
| # imagePullPolicy: Always # add for development | |||
There was a problem hiding this comment.
Note part of the diff technically, but since you're in the neighborhood, maybe add a newline here?
examples/xonotic/main.go
Outdated
| @@ -18,22 +18,93 @@ import ( | |||
| "log" | |||
| "time" | |||
|
|
|||
There was a problem hiding this comment.
The following imports can be moved up one line to be next to log and time.
examples/xonotic/main.go
Outdated
| } | ||
|
|
||
| // Write will intercept the incoming stream, and forward | ||
| // the contents to it's `forward` Writer. |
Change the Xonotic example to have wrapper around the server execution, and use the content of stdout to determine what to do with the SDK for GameServer lifecycle management.
markmandel
force-pushed
the
feature/xonotic-wrapper
branch
from
f532299
to
6bb72a3
Compare
|
Build Succeeded 👏 Build Id: 89a804d1-addb-4d39-b61c-25bed3af95db The following development artifacts have been built, and will exist for the next 30 days:
|
enocom
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Xonotic example to have wrapper around the server execution, and use the content of stdout to determine what to do with the SDK for GameServer lifecycle management.